New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency_script - only verify checksum of new downloads #541

Merged
merged 2 commits into from Aug 18, 2016

Conversation

Projects
None yet
2 participants
@peterjc
Copy link
Contributor

peterjc commented Aug 17, 2016

This is a refinement to #538 from earlier today, which has been working nicely but makes using planemo dependency_script painfully slow if you already have the files downloaded and cached because it will verify their checksums.

I'm wondering about going further and putting this under a --verify switch (like the commented out one proposed for planemo shed_lint), since as used on my TravisCI setup the checksums are run twice (once via planemo dependency_script and again via bash dep_install.sh).

@peterjc

This comment has been minimized.

Copy link
Contributor Author

peterjc commented Aug 17, 2016

Updated the deb_install.sh output to also only run shasum -a 256 ... if the file has been freshly downloaded.

This should solve the potential overhead on my TravisCI usage - the files should be downloaded and the checksum will be verified once only.

@peterjc peterjc added the enhancement label Aug 17, 2016

@jmchilton jmchilton merged commit 20ead37 into galaxyproject:master Aug 18, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Aug 18, 2016

Awesome - thanks for the refinement. This seems like a good compromise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment