Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify sha256sum checksums in planemo dependency_script #538

Merged
merged 4 commits into from
Aug 17, 2016

Conversation

peterjc
Copy link
Contributor

@peterjc peterjc commented Aug 17, 2016

In addition this fixes a problem trying to run the script without setting $DOWNLOAD_CACHE (documented as defaulting to ./download_cache) or if the local cache folder did not exist.

@peterjc
Copy link
Contributor Author

peterjc commented Aug 17, 2016

This has been tested locally while updating the MIRA tool_dependencies.xml files:

peterjc/galaxy_mira@a7c7640
peterjc/galaxy_mira@7eb9dbe

Once incorporated into an official planemo release this would get tested on TravisCI via https://github.com/peterjc/galaxy_mira and (once I record more checksums in their tool_dependencies.xml files) my other repositories.

@jmchilton jmchilton merged commit f88f055 into galaxyproject:master Aug 17, 2016
@jmchilton
Copy link
Member

Thanks a bunch - I'll try to do a release today.

@peterjc
Copy link
Contributor Author

peterjc commented Aug 17, 2016

Thanks John - I'll keep an eye on my TravisCI tool tests using planemo dependency_script once the next planemo release is out - just in case it flags are any side effects.

@peterjc
Copy link
Contributor Author

peterjc commented Aug 17, 2016

Performance issue addressed in #541.

Also found this is missing checksum verification in the dep_install.sh from a download_file action, e.g. https://github.com/peterjc/pico_galaxy/blob/master/tools/effectiveT3/tool_dependencies.xml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants