Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 2.7 support in standard transport, drop Python 2.7 tests and fix Python 3.7 wheel install test, general test debugging enhancements #231

Merged
merged 11 commits into from
Sep 16, 2020

Conversation

natefoo
Copy link
Member

@natefoo natefoo commented Aug 11, 2020

It's not going to work on 2.7 much longer anyway as galaxy-lib no longer supports 2.7.

@natefoo
Copy link
Member Author

natefoo commented Aug 11, 2020

We can also just leave Paste and PasteScript in the requirements.txt, but they're unnecessary in a webless install.

@coveralls
Copy link

coveralls commented Aug 11, 2020

Coverage Status

Coverage decreased (-0.003%) to 80.321% when pulling ee943ca on natefoo:drop-py27-tests into c9c7327 on galaxyproject:master.

@bgruening
Copy link
Member

It seems we still have a paste-test that fails: https://travis-ci.org/github/galaxyproject/pulsar/jobs/717076970#L947

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[testenv:py27-install-wheel]

Should that be removed as well?

@natefoo
Copy link
Member Author

natefoo commented Sep 15, 2020

[testenv:py27-install-wheel]

Should that be removed as well?

Yep, thanks.

@natefoo natefoo changed the title Drop Python 2.7 tests and WIP fix Python 3.7 wheel install test Drop Python 2.7 support in standard transport, drop Python 2.7 tests and fix Python 3.7 wheel install test, general test debugging enhancements Sep 15, 2020
pulsar-check to aid in debugging test problems. Setting the env var also
disables cleanup (which now also prevents cleanup of the test client
directory as well as the server directory). Also, givee the client and
server tempdirs meaningful names so that it's more obvious what you're
looking at.
@bgruening
Copy link
Member

Cool, thanks Nate!

@bgruening bgruening merged commit 8d22f77 into galaxyproject:master Sep 16, 2020
@jmchilton
Copy link
Member

Looks good to me - thanks for all the work @natefoo !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants