sync GH actions with IUC #582
Conversation
.github/workflows/pr.yaml
Outdated
| @@ -203,7 +238,7 @@ jobs: | |||
| - name: lintr | |||
| run: | | |||
| library(lintr) | |||
| linters <- with_defaults(line_length_linter = NULL, cyclocomp_linter = NULL) | |||
| linters <- with_defaults(line_length_linter = NULL, object_usage_linter = NULL) | |||
There was a problem hiding this comment.
Should we keep cyclocomp_linter = NULL (added in commit 4e17a8d )?
There was a problem hiding this comment.
Probably yes and we should also add it to the IUC workflow, or?
There was a problem hiding this comment.
I suppose it would make life easier on tools-iuc too.
There was a problem hiding this comment.
done. and galaxyproject/tools-iuc#3398
| - name: Install Planemo | ||
| run: pip install planemo | ||
| - name: Deploy on testtoolshed | ||
| env: | ||
| SHED_KEY: ${{ secrets.tts_api_key }} | ||
| SHED_KEY: ${{ secrets.TTS_API_KEY }} |
There was a problem hiding this comment.
@nsoranzo do you know if the change to uppercase requires an update of the settings?
There was a problem hiding this comment.
Yes, it does need someone with admin privileges on this repo to remove and re-add the TTS and TS API key secrets.
There was a problem hiding this comment.
OK. Given the activity on this repo we can ask for this change after this is merged.
There was a problem hiding this comment.
I doubt this is needed, we have uppercase version in the secrets since June
There was a problem hiding this comment.
I remember that they are shown upper case even if entered lower case. But we can just try with one of my long open PRs :)
There was a problem hiding this comment.
@bernt-matthias lol, in that case I have no idea what we have. I am ready to change it if it fails though.
bernt-matthias
force-pushed
the
topic/sync-ghactions
branch
from
458d94c
to
c332641
Compare
|
Ready to go? |
|
Seems that deployment works https://github.com/galaxyproject/tools-devteam/actions/runs/451752521 |
seems that the PR workflow does not work anymore, because of
set-env. Guess its about time to sync the workflows again.