Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First version of fermi2 / fermikit variant caller #1093

Merged
merged 6 commits into from
Jan 5, 2017

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jan 2, 2017

Fermikit can be used to call variants from high coverage short read sequencing
data.

@mvdbeek mvdbeek changed the title First version of fermi2 / fermikit variant caller WIP: First version of fermi2 / fermikit variant caller Jan 2, 2017
@mvdbeek mvdbeek changed the title WIP: First version of fermi2 / fermikit variant caller First version of fermi2 / fermikit variant caller Jan 3, 2017
@bgruening
Copy link
Member

tools/fermikit/.fermi2.xml.swo should be removed, isn't it?

<tool id="fermi2" name="fermi2" version="0.14.dev1">
<description>assembles Illumina reads into unitigs</description>
<requirements>
<requirement type="package" version="r193">fermi2</requirement>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentaion

@@ -0,0 +1,65 @@
<tool id="fermi2" name="fermi2" version="0.14.dev1">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the version number correct? dev seems wired to me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see the versions are different between the tools:

+        <requirement type="package" version="0.14.dev1">fermikit</requirement>

So fermikit is a bunch of tools and fermi2 is a workflow/makefile thingy?

Copy link
Member Author

@mvdbeek mvdbeek Jan 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a fermi2 binary, that focuses on the exploration of FMD-index as a graph. It relies on fermi or ropebwt2 for index construction. fermi2.pl is a wrapper with which you can then do an assembly, and fermikit includes fermi2, bwa, trimadap etc so that you can go from raw reads to variant calls based on the assembly done by fermi2. I split the fermikit functionality into the assembly (using the fermi2 wrapper), mapping (using the standard bwa-mem wrapper with intractg option) and variant calling (with the fermikit_variants wrapper). I suppose we could rely on multiple exact conda packages instead of the fermikit package, if you prefer that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and I chose version 0.14dev1 because the dependencies in the fermikit conda package match the current master (see https://github.com/lh3/fermikit/blob/master/NEWS.md)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, makes somehow sense :)

@bgruening bgruening merged commit 16dcfc0 into galaxyproject:master Jan 5, 2017
@bgruening
Copy link
Member

Thanks!

@mvdbeek
Copy link
Member Author

mvdbeek commented Jan 5, 2017

Thanks Bjoern!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants