Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data manager for pangoLEARN #3617

Merged
merged 12 commits into from Apr 24, 2021
Merged

Add data manager for pangoLEARN #3617

merged 12 commits into from Apr 24, 2021

Conversation

pvanheus
Copy link
Contributor

@pvanheus pvanheus commented Apr 22, 2021 •
edited

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

@pvanheus
Copy link
Contributor Author

This is a data manager for the pangoLEARN database, which is used by the pangolin tool.

When this DM is merged, the pangolin tool will be updated to use this DM.

abretaud
abretaud reviewed Apr 22, 2021
View reviewed changes
Copy link
Contributor

@abretaud abretaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments, looks good apart from that 👍

data_managers/data_manager_pangolearn/.vscode/settings.json Outdated Show resolved Hide resolved
data_managers/data_manager_pangolearn/data_manager/pangolearn_dm.xml Outdated Show resolved Hide resolved
data_managers/data_manager_pangolearn/data_manager_conf.xml Show resolved Hide resolved
@pvanheus pvanheus mentioned this pull request Apr 22, 2021
Merged
5 tasks
@bgruening bgruening merged commit 68adfad into galaxyproject:master Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abretaud abretaud abretaud left review comments

@bgruening bgruening bgruening approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pvanheus @abretaud @bgruening