Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pangolin: Add database usage options #3620

Merged
merged 8 commits into from Apr 25, 2021
Merged

Update pangolin: Add database usage options #3620

merged 8 commits into from Apr 25, 2021

Conversation

pvanheus
Copy link
Contributor

@pvanheus pvanheus commented Apr 22, 2021

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

@pvanheus
Copy link
Contributor Author

As discussed on Galaxy Public Health Gitter, the pangolin tool should specify options for using a specific pangoLEARN DB. Either

  1. Download the latest version and use that
  2. Use a version built in to the Galaxy server (from a data table)
  3. Use the "default" version installed with pangolin (not recommended)

The choice between 1 and 2 will depend on the configuration of the Galaxy server, its internet connectivity, etc.

This is WIP as the builtin DB option is waiting for #3617 to get merged.

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pvanheus you need to add the boilerplate loc files and the
tool_data_table_conf.xml.sample files.

Ideally, you could add a test as well for the loc file option. See for example this one as an example: https://github.com/galaxyproject/tools-iuc/tree/master/tools/artic

@pvanheus pvanheus changed the title Update pangolin: Add database usage options [WIP] Update pangolin: Add database usage options Apr 25, 2021
@pvanheus
Copy link
Contributor Author

@pvanheus you need to add the boilerplate loc files and the
tool_data_table_conf.xml.sample files.

Ideally, you could add a test as well for the loc file option. See for example this one as an example: https://github.com/galaxyproject/tools-iuc/tree/master/tools/artic

Yes, that is what is in the latest set of commits. I have now removed the WIP as I think this is ready for review.

@bgruening bgruening merged commit 1522bdb into galaxyproject:master Apr 25, 2021
@pvanheus pvanheus deleted the pangolin_update branch June 2, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants