-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bio_hansel: allow gz input #3639
Conversation
tools/hansel/bio_hansel.xml
Outdated
#if $data_type.fastq_input1.is_of_type('fastqsanger') or $data_type.fastq_input1.is_of_type('fastq'): | ||
#if $data_type.fastq_input1.is_of_type('fastqsanger') or $data_type.fastq_input1.is_of_type('fastqsanger.gz') or $data_type.fastq_input1.is_of_type('fastq') or $data_type.fastq_input1.is_of_type('fastq.gz'): | ||
fast_q_single.fastq | ||
#end if | ||
|
||
#if $data_type.fastq_input1.is_of_type('fasta'): | ||
#elif $data_type.fastq_input1.is_of_type('fasta') or $data_type.fastq_input1.is_of_type('fasta.gz'): | ||
fast_a_single.fasta | ||
#end if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#if $data_type.fastq_input1.is_of_type('fastqsanger') or $data_type.fastq_input1.is_of_type('fastq'): | |
#if $data_type.fastq_input1.is_of_type('fastqsanger') or $data_type.fastq_input1.is_of_type('fastqsanger.gz') or $data_type.fastq_input1.is_of_type('fastq') or $data_type.fastq_input1.is_of_type('fastq.gz'): | |
fast_q_single.fastq | |
#end if | |
#if $data_type.fastq_input1.is_of_type('fasta'): | |
#elif $data_type.fastq_input1.is_of_type('fasta') or $data_type.fastq_input1.is_of_type('fasta.gz'): | |
fast_a_single.fasta | |
#end if | |
#if $data_type.fastq_input1.ext.startswith("fastq") | |
fast_q_single.fastq | |
#else | |
fast_a_single.fasta | |
#end if |
Maybe this simplifies also elsewhere.
tools/hansel/macros.xml
Outdated
<xml name="requirements"> | ||
<requirements> | ||
<requirement type="package" version="2.6.1">bio_hansel</requirement> | ||
<requirement type="package" version="20.3.0">attrs</requirement> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know what attrs
is doing here?
…from initial review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go?
Thanks @gregvonkuster and @bernt-matthias |
FOR CONTRIBUTOR: