Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update download_idr #4328

Merged
merged 7 commits into from
Jan 15, 2022
Merged

Conversation

lldelisle
Copy link
Contributor

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

This allow to download original images in galaxy. This is not usable in idr but in private instances... Then I don't know how to do a proper test...

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lldelisle thanks. Increase the profile and the tool version?

tools/idr_download/idr_download_by_ids.xml Show resolved Hide resolved
tools/idr_download/idr_download_by_ids.xml Outdated Show resolved Hide resolved
@lldelisle
Copy link
Contributor Author

Do you know to what the tool version 0.43 stand for?

@lldelisle
Copy link
Contributor Author

Why should I update the profile? If it is compatible with 18.09 we should keep it, no?

@bgruening
Copy link
Member

Do you know to what the tool version 0.43 stand for?

No idea, sorry.

Why should I update the profile? If it is compatible with 18.09 we should keep it, no?

We get more isolations from Galaxy for tools with higher profile number. But its not needed.

@bgruening bgruening merged commit b687159 into galaxyproject:master Jan 15, 2022
@bgruening
Copy link
Member

Thanks @lldelisle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants