Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows updated with newer tools, added missing #1732

Merged
merged 18 commits into from
Mar 15, 2020

Conversation

astrovsky01
Copy link
Contributor

No description provided.

@astrovsky01 astrovsky01 requested review from a team as code owners January 27, 2020 14:27
@astrovsky01
Copy link
Contributor Author

How do I lint a workflow? I took what came from downloading off of an instance.

@bgruening
Copy link
Member

source /home/travis/miniconda3/bin/activate galaxy_training_material && \
	bash bin/validate-json.sh && \
	bash bin/validate-workflow-tags.sh

@bedroesb
Copy link
Contributor

bedroesb commented Feb 4, 2020

@astrovsky01 Since #1724 and #1715 it is mandatory for a workflow on GTN to have the correct tags and annotation. I will add this workflow linting to planemo hopefully this week. You could fix this travis error easily by editing the workflow file. Make sure following attributes are filled in like this:

"annotation": "Unicycler Assembly",
...
...
"tags": [	    
    "assembly"
  ]

and

"annotation": "De novo transcriptome reconstruction with RNA-Seq",
...
...
"tags": [
    "transcriptomics"	
  ],

in the other file

@astrovsky01
Copy link
Contributor Author

@bedroesb thank you, I appreciate it!

@bedroesb
Copy link
Contributor

bedroesb commented Feb 4, 2020

@astrovsky01 no problem ! We hope that if these workflows are than added to an instance, people can find them back easier.

@almahmoud
Copy link
Member

Probably not necessary, but I'd also suggest changing the names to remove the numbering we're using internally (i.e. WF2, WF4) and just match the tutorial name

@astrovsky01 astrovsky01 requested a review from a team as a code owner February 7, 2020 17:29
@astrovsky01 astrovsky01 requested a review from a team as a code owner February 7, 2020 17:31
@bgruening
Copy link
Member

@astrovsky01 have you checked that those workflows also follow the training material? Do we need to adjust the hands-on material because of parameter changed etc...?

@astrovsky01 astrovsky01 requested a review from a team as a code owner February 13, 2020 16:40
@astrovsky01
Copy link
Contributor Author

@bgruening they don't change the training, except the ones I added to the PR. It's more about updating tools to most recent versions.

@astrovsky01
Copy link
Contributor Author

@bgruening Does anything else need to be changed?

@bgruening bgruening merged commit ed381ad into galaxyproject:master Mar 15, 2020
@bgruening
Copy link
Member

Sorry for the delay, didn't get any notification for the last 2 weeks, trying to catch up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants