Module leaves entries unhandled on upgrade

[hhenkel]

Red Hat decided to remove the "shpchp" kernel module in RHEL 7.6. When upgrading a machine from RHEL 7.5 to 7.6 where the "shpchp" module was previously managed it seems like you end up in a state where you can't get rid of it.

Wouldn't it be better to manage the whole file / the complete content of the files from the module?

[galexrt]

@hhenkel The file is managed but only when for adding a module.
When autoload: false it should also be removed, which is currently not implemented.

ansible-kernel-modules/tasks/load-modules.yml

Line 16 in 83f14ee

state: present

needs to be absent when autoload: false and the other way around.

Do you see this as a way to fix your issue or would adding state: (absent|present) for the modules sound better?

[hhenkel]

@galexrt I think it might be much easier not to use "lineinfile" but create the file as a whole with the data provided.
I think it is counter intuitive to set something to absent - imho it makes more sense to have everything in a file if it is explicitly mentioned.

I can do a poc and create a pr if it is easier to discuss.

[galexrt]

@hhenkel A poc PR sounds good! 👍