Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CocoaPod and Framework product in repo are outdated #49

Closed
kevincon opened this issue Sep 8, 2014 · 15 comments
Closed

CocoaPod and Framework product in repo are outdated #49

kevincon opened this issue Sep 8, 2014 · 15 comments
Labels

Comments

@kevincon
Copy link
Collaborator

kevincon commented Sep 8, 2014

The README says to use this line in a Podfile:
pod 'TesseractOCRiOS', '~> 2.3'

But the CocoaPods master repo does not have version 2.3 (latest is 2.22): http://cocoapods.org/?q=tesseract

I got around this by using this line in my Podfile:
pod 'TesseractOCRiOS', :git => 'https://github.com/gali8/Tesseract-OCR-iOS.git'

But the current Products/TesseractOCR.framework file in the repo is an older version that does not include the getConfidenceByX properties on the Tesseract class, so I am unable to use those.

Can someone please update the framework file stored in the repo to reflect the changes in version 2.3? Additionally, can someone submit version 2.3 to CocoaPods?

Thanks!

@kevincon
Copy link
Collaborator Author

I saw that in ee6061d @gali8 updated the README Podfile snippet to point to version 2.2 with the comment "2.3 is not yet available, I'm sorry."

I don't mean to be rude, but since 2.3 has been marked as a release tag on Github, why can't you just push it to the Cocoapods master repo so users can start pulling it from Cocoapods to use in the projects?

@zachberger
Copy link
Collaborator

Can we get a status update on this?

@thuantta
Copy link

Yes please update to CocoaPods

@3a4oT
Copy link

3a4oT commented Nov 29, 2014

+1

@zachberger
Copy link
Collaborator

In lieu of the maintainer of this repo responding, I'd suggest someone forking the repo and making their own submission to cocoapods. I'd be willing to keep cocoapods up-to-date, however I don't have the resources currently to keep the core tesseract-ocr library up to date. Perhaps someone would like to collaborate on this? @kevincon? Ideally more than one person would be marked as contributor on the new fork so that if one person becomes unavailable the entire project doesn't come to a complete standstill.

@kevincon
Copy link
Collaborator Author

@zachberger I was also thinking about a solution like this. @gali8 has done a lot of fantastic work with this library, but the slow/never responses to issues and lack of active work and CocoaPods updates are unacceptable for the sole contributor of an open-source project that is used by so many people like this one.

Personally I'd prefer it if we didn't fork the repo just for the purpose of updating the CocoaPod, so I have a proposal in two parts:

  1. @gali8, can you make @zachberger and me contributors for your repo so we can help resolve issues and accept pull requests? You'll still remain the owner and therefore retain control over the repo, but this will allow us to help keep the repo more up-to-date. I've been able to respond to the last 4 issues submitted within about a day.
  2. Additionally, since CocoaPods does not allow you to delete a podspec, I propose that @gali8 add the following line to his podspec file and push it to CocoaPods to deprecate his version of the CocoaPod in favor of a podspec that I can maintain:

spec.deprecated_in_favor_of = 'TesseractOCR'

Then I'll create the new podspec in this repo and push it to CocoaPods so we can start enjoying up-to-date CocoaPods releases.

I agree that if @gali8 does not respond then we have no other choice but to fork the library and work to make it the new central repository for this project. I'd be happy to take ownership of the fork and maintain it as well as make @zachberger a contributor (along with anyone else who actively contributes to the project).

What do you guys think about that plan?

@zachberger
Copy link
Collaborator

Just a quick message as I'm heading out:

  • I cannot thank @gali8 enough for his creation and hard work on this project.
  • I do think it would be best if this was left unforked. This repo has significant visibility, with nearly 750 stars.

@kevincon
Copy link
Collaborator Author

kevincon commented Dec 2, 2014

To put a timetable on this, I propose we move forward with a separate fork if @gali8 does not respond by December 15.

@3a4oT
Copy link

3a4oT commented Dec 2, 2014

@kevincon can you fork this repository and take leadership on it??

@gali8
Copy link
Owner

gali8 commented Dec 2, 2014

Dear guys, i like your work. How you can suppose, this is not the only project when I'm working.
So, my time is really limited now.
@zachberger and @kevincon I will add you like collaborators for this repo.

@gali8
Copy link
Owner

gali8 commented Dec 2, 2014

Done. Enjoy!

@zachberger zachberger added the bug label Dec 2, 2014
@zachberger
Copy link
Collaborator

The latest versions have now been tagged by @gali8 and pushed to the CocoaPods repo.

The corresponding commits in this repo are:
v3.1 8849936
v3.03 99ee187

@kevincon
Copy link
Collaborator Author

kevincon commented Dec 2, 2014

Thank you @gali8!

@gali8
Copy link
Owner

gali8 commented Dec 2, 2014

The only different between 3.1 and 3.03 is in the readme file.

You are welcome!

@thuantta
Copy link

thuantta commented Dec 2, 2014

Thanks you guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants