Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIP package nmap has nothing to do with the port scanner #43

Closed
Pamplemousse opened this issue Apr 20, 2020 · 2 comments · Fixed by #44
Closed

PIP package nmap has nothing to do with the port scanner #43

Pamplemousse opened this issue Apr 20, 2020 · 2 comments · Fixed by #44
Assignees
@g0tmi1k
Labels
bug

Comments

@Pamplemousse
Copy link
Contributor

The referenced nmap python package in requirements.txt has nothing to do with the port scanner; See: https://pypi.org/project/nmap/ .

The test to see if either the binary is present in https://github.com/galkan/crowbar/blob/c2d8da1db2d5ce57c8984f92e4a177075cd5d47c/lib/nmap.py#L19-L28 could be simplified (as imported the nmap from pip is certainly of no help).
@Pamplemousse Pamplemousse changed the title The PIP package nmap has nothing to do with the port scanner PIP package nmap has nothing to do with the port scanner Apr 21, 2020
@g0tmi1k
Copy link
Collaborator

g0tmi1k commented Apr 21, 2020

Feel free to put in a PR to correct it :)

@Pamplemousse Pamplemousse mentioned this issue Apr 22, 2020
Merged
@g0tmi1k g0tmi1k self-assigned this Apr 23, 2020
@g0tmi1k g0tmi1k added the bug label Apr 23, 2020
@g0tmi1k
Copy link
Collaborator

g0tmi1k commented Apr 23, 2020

Cheers for putting in the time to follow up and do a PR <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@g0tmi1k g0tmi1k

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

nmap on PIP is not related to the port scanner
2 participants
@g0tmi1k @Pamplemousse