Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added nside overide for template component class #50

Merged
merged 2 commits into from
Apr 3, 2020
Merged

Added nside overide for template component class #50

merged 2 commits into from
Apr 3, 2020

Conversation

b-thorne
Copy link
Collaborator

@b-thorne b-thorne commented Apr 3, 2020

Potential fix to #37 by adding nside keyword to Model.read_map to override the Model's usual nside.

@b-thorne b-thorne requested a review from zonca April 3, 2020 18:47
zonca
zonca requested changes Apr 3, 2020
View reviewed changes
Copy link
Member

@zonca zonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good, just add docstring

pysm/models/template.py Show resolved Hide resolved
@zonca zonca merged commit e127ac8 into hd17 Apr 3, 2020
@zonca zonca deleted the hd_17_fix branch April 3, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zonca zonca zonca requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@b-thorne @zonca