-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of HD2017 dust model #37
Conversation
…accumulate for bandpass average.
@bthorne93 I'm finally back working on this, I have implemented unit tests, they don't pass!
PySM 3 does the calculation on float32 to save memory, but I don't think that is enough to explain the difference, what do you think? |
@zonca My first guess would be that this is just a result of the random generation of part of the spectral model using a different seed. We would need to check exactly how |
I created check_d7_353_64.fits |
See the notebook above here about how I created that test file |
freq_ref_I = "545 GHz" | ||
freq_ref_P = "353 GHz" | ||
rnd_uval = true | ||
seed = 4632 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bthorne93
Compare to PySM2: https://github.com/bthorne93/PySM_public/blob/master/pysm/nominal.py#L122
Okay, doesn't seem to be that, the code setting the seed and doing the random generating is identical in the two versions. I'll take a deeper look now. |
The original pysm2 random generation was always done at nside 256, however the faulty implementation is doing the random generation on templates ud_graded to the model's nside. I've got the right results by adding an nside keyword to the model's read_map function. This might not be desirable, so can figure out a way to hard code the reading at 256 if that is preferred. |
Added nside overide for template component class
@bthorne93 can you also rebase on master, so the unit tests run |
@zonca Since it's a destructive operation, and I'm not comfortable enough with my git skills, would you mind doing that? I've added the docstring above. |
@bthorne93 sure, no problem |
@bthorne93 rebase was too messy, I merged! tests pass on my machine! |
Great! Should I merge? |
no, I'll make sure everything passes on travis then merge |
Not sure why github is not showing the travis builds feedback anymore. https://travis-ci.org/github/healpy/pysm/builds/670830673 excellent, thanks @bthorne93 ! |
No description provided.