Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.1.0 causing activation to fail when using manual offline activation #253

Closed
poi-vrc opened this issue Dec 14, 2023 · 5 comments
Closed
Labels
bug Something isn't working

Comments

@poi-vrc
Copy link

poi-vrc commented Dec 14, 2023

Bug description

I was previously using game-ci/unity-test-runner@v4 on my builds. And activated Unity personal edition in GitHub Actions using the manual activation method for months:
game-ci/documentation#408

How to reproduce

Activate using manual activation and paste the ulf content as a secret in UNITY_LICENSE.
Use game-ci/unity-test-runner@v4 in the workflow file, which will resolve to v4.1.0 and run a build.
The activation will fail.
image

  • Expected behavior

Successfully activate, build and test.

Additional details

Reverting to v4.0.0 by using game-ci/unity-test-runner@v4.0.0 can activate successfully.

@poi-vrc poi-vrc added the bug Something isn't working label Dec 14, 2023
@AndrewKahr
Copy link
Member

Did you pass in UNITY_EMAIL and UNITY_PASSWORD in addition to the license?

@poi-vrc
Copy link
Author

poi-vrc commented Dec 14, 2023

No, I did not pass those secrets. It was working without the email and password previously.
Are they required since v4.1.0?

@AndrewKahr
Copy link
Member

Indeed it is now required. It was actually supposed to be required since v4.0.0 but the code didn't align with Unity-Builder properly. I will update the release notes to make that more clear

@AndrewKahr
Copy link
Member

I should also note it needs to be the same credentials as the account used to activate the license.

Apologies for the inconvenience!

@poi-vrc
Copy link
Author

poi-vrc commented Dec 14, 2023

Thanks. I will modify my workflows later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants