Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Omniflix denom query not working for IBC transferred denoms #188

Closed
gjermundgaraba opened this issue Mar 2, 2023 · 4 comments
Closed

Comments

@gjermundgaraba
Copy link
Contributor

gjermundgaraba commented Mar 2, 2023

The scope of bugs are not 100% clear, so not sure if this qualifies as a bug in the program or not. If not I will file it with Omniflix directly.

Summary of Bug

When using the following command with the OmniFlix cli, there is some validation of the "ID" that is not taking IBC-denoms into account:

$ omniflixhubd q onft denom ibc/A7E0CED936458907B4A7635B0E2A63F540A84FE45C36C96CEC106D8D47C2D743
Error: invalid denom ID ibc/A7E0CED936458907B4A7635B0E2A63F540A84FE45C36C96CEC106D8D47C2D743, only accepts alphanumeric characters, and begin with an english letter: invalid denom

Interestingly enough, it works fine if you query using collection instead of denom.

Environment

  • OS: Linux, Ubuntu 22.04
  • Software version: omniflixhubd 0.9.0-gon-test

Steps to Reproduce

  1. Transfer an NFT to OmniFlix
  2. Find the class hash (q nft-transfer class-hash)
  3. Query for denom using the form ibc/<CLASS_HASH>

Another approach you can take is to query for all denoms, find any that has the ibc/<CLASS_HASH> format and try to query for that one directly (which will also fail).

Expected and Actual Behavior

It should see the format as valid and query for the IBC-transferred NFT.

@harish551
Copy link

Hey @gjermundgaraba

can you use the latest version binary

v0.9.0-gon-test2

@gjermundgaraba
Copy link
Contributor Author

@harish551 that does indeed work. That version is however not the version in the instructions.

@harish551
Copy link

@gjermundgaraba Yes we forgot to update latest version in the docs.
(I thought it would be okay as query issues are fixed in the rpc node you are using but this validation happens directly in the binary so we should definitely update to new version )

@taramakage taramakage added the bug Something isn't working label Mar 3, 2023
@taramakage taramakage added client omniflix and removed bug Something isn't working labels Mar 27, 2023
@taramakage
Copy link
Member

I think this issue should have been resolved by now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants