Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One file is GPL, everything else is MIT? #15

Closed
JeetKunDoug opened this issue Sep 27, 2016 · 5 comments · Fixed by #16
Closed

One file is GPL, everything else is MIT? #15

JeetKunDoug opened this issue Sep 27, 2016 · 5 comments · Fixed by #16

Comments

@JeetKunDoug
Copy link

JeetKunDoug commented Sep 27, 2016

https://github.com/GameAnalytics/hyper/blob/master/c_src/hyper_carray.c#L5 claims the C implementation of hyper_carray as GPL, but the LICENSE file is MIT. Can you clarify which license this library falls under, and perhaps drop the GPL header from hyper_carray.c if the intent is for it to be MIT licenced? For the moment, we're dropping the hyper_carray backend from our fork before shipping HLL support in Riak (as we're currently using the hyper_binary backend anyway). We originally found this because we ran into issues compiling hyper_carray.c on Solaris, one of our target operating systems.

@elverkilde
Copy link
Contributor

That's not good. The C implementation was originally a separate project which was merged in and the license was probably forgotten.

I guess the preferred solution is to change the license to MIT. We will need permission from all contributors AFAIK. My permission is hereby given.

Can you submit a separate PR with the Solaris fix? It would be great to have that in.

cc @johannesh @chrisavl @cmdevries

@binarytemple-external
Copy link

binarytemple-external commented Oct 4, 2016

Just for the point of clarity - https://github.com/GameAnalytics/hyper/blob/master/c_src/hyper_carray.c#L5 - that line says LGPL. Not to diminish the importance of a consistent license, but worth mentioning that LGPL code will not contaminate an entire codebase in the same manner as GPL licensed code. This ticket should be renamed.

@complex64
Copy link

@elverkilde, go for the MIT for carray for this project 👍

@renjith-ga
Copy link
Contributor

Merged the pull request from @elverkilde as the permission has been given by all three contributors @elverkilde @chrisavl and @johannesh to change license to MIT. Hence closing this issue.

@cmdevries
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants