IDE-3359: Add Mojos for transpile and config #53

christopherbryanboyd · 2017-11-28T21:43:27Z

No description provided.

liferay-continuous-integration · 2017-11-28T21:43:29Z

Pull request test invoked at http://test-1-20.liferay.com/job/test-portal-acceptance-pullrequest(master).

gamerson

Also, did you try this in the IDE (after building locally) to verify that it works and fixes the problem?

gamerson · 2017-11-28T22:23:21Z

...oject-templates/project-templates-soy-portlet/src/main/resources/archetype-resources/pom.xml

 				<executions>
 					<execution>
-						<id>transpile-js</id>
+                        <id>transpile-js</id>


gamerson · 2017-11-28T22:26:31Z

...oject-templates/project-templates-soy-portlet/src/main/resources/archetype-resources/pom.xml

-							</arguments>
-						</configuration>
+                        <configuration>
+                            <nodePath>${project.build.directory}/node/node</nodePath>


lets add Defaults for the following variables and remove them from the pom

bundleFileName
format
globalName
moduleName
soySrcs
soySrc
srcs
src

gamerson · 2017-11-28T22:26:37Z

...oject-templates/project-templates-soy-portlet/src/main/resources/archetype-resources/pom.xml

 					</execution>
 					<execution>
-						<id>config-js-modules</id>
+                        <id>config-js-modules</id>


gamerson · 2017-11-28T22:27:37Z

...oject-templates/project-templates-soy-portlet/src/main/resources/archetype-resources/pom.xml

+                            <nodePath>${project.build.directory}/node/node</nodePath>
+                            <workingPath>${project.build.outputDirectory}/META-INF/resources</workingPath>
+                            <modulePath>${node.modules.dir}/liferay-module-config-generator/bin/index.js</modulePath>
+                            <config></config>


also set defaults for these and remove them from configuration
config
extension
format
ignorePath
namespace

gamerson · 2017-11-28T22:27:52Z

...oject-templates/project-templates-soy-portlet/src/main/resources/archetype-resources/pom.xml

 					<execution>
+                        <id>replace-translation</id>


gamerson · 2017-11-28T22:29:23Z

...util/portal-tools-soy-builder/src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml

@@ -5,6 +5,8 @@
 		<pluginExecution>
 			<pluginExecutionFilter>
 				<goals>
+					<goal>transpile-js</goal>
+					<goal>config-js-modules</goal>
 					<goal>build</goal>


What does the build goal do? do we need it? it seems out of place now

liferay-continuous-integration · 2017-11-29T02:34:42Z

The pull request tester is still running.

Please wait until you get the final report before running 'ci:retest'.

See this link to check on the status of your test:

test-portal-acceptance-pullrequest(master)

@christopherbryanboyd

However, the pull request was closed.

The pull request was closed because the following critical batches had failed:

source-format-jdk8

For information as to why we automatically close out certain pull requests see this article.

*This pull will no longer automatically close if this comment is available. If you believe this is a mistake please re-open this pull by entering the following command as a comment.

ci:reopen

Critical Failure Details:

test-portal-acceptance-pullrequest-batch(master)/source-format-jdk8

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #191461

     [exec] :util:source-formatter:classes
     [exec] :util:source-formatter:jar
     [exec] :util:source-formatter:deploy
     [exec] Files of project ':util:source-formatter' deployed to /opt/dev/projects/github/liferay-portal/tools/sdk/dependencies/com.liferay.source.formatter/lib
     [exec] :util:source-formatter:deployDependencies UP-TO-DATE
     [exec] 
     [exec] BUILD SUCCESSFUL
     [exec] 
     [exec] Total time: 27.95 secs
     [exec] Gradle build finished at 2017-11-29 02:28:52.938.
     [exec] 
     [echo] Running com.liferay.source.formatter.jar 1.0.503.
format-source:

[java] Loading file:/opt/dev/projects/github/liferay-portal/portal-impl/classes/system.properties

[java] SLF4J: Class path contains multiple SLF4J bindings.

[java] SLF4J: Found binding in [file:/opt/dev/projects/github/liferay-portal/util-slf4j/classes/org/slf4j/impl/StaticLoggerBinder.class]

[java] SLF4J: Found binding in [jar:file:/opt/dev/projects/github/liferay-portal/lib/development/slf4j-simple.jar!/org/slf4j/impl/StaticLoggerBinder.class]

[java] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.

[java] SLF4J: Actual binding is of type [com.liferay.util.sl4fj.LiferayLoggerFactory]

[java] /opt/dev/projects/github/liferay-portal/modules/sdk/gradle-plugins-soy/build.gradle

[java] /opt/dev/projects/github/liferay-portal/modules/sdk/project-templates/project-templates-soy-portlet/src/main/resources/archetype-resources/pom.xml

[java] Exception in thread "main" com.liferay.source.formatter.SourceMismatchException: ./modules/sdk/gradle-plugins-soy/build.gradle expected:&lt;...1", "3.2.1", "3.3"

[java] }[]> but was:&lt;...1", "3.2.1", "3.3"

[java] }[

[java] ]>

[java] 	at com.liferay.source.formatter.BaseSourceProcessor.processFormattedFile(BaseSourceProcessor.java:396)

[java] 	at com.liferay.source.formatter.BaseSourceProcessor.format(BaseSourceProcessor.java:281)

[java] 	at com.liferay.source.formatter.BaseSourceProcessor._format(BaseSourceProcessor.java:522)

[java] 	at com.liferay.source.formatter.BaseSourceProcessor._performTask(BaseSourceProcessor.java:630)

[java] 	at com.liferay.source.formatter.BaseSourceProcessor.access$000(BaseSourceProcessor.java:68)

[java] 	at com.liferay.source.formatter.BaseSourceProcessor$1.call(BaseSourceProcessor.java:114)

[java] 	at com.liferay.source.formatter.BaseSourceProcessor$1.call(BaseSourceProcessor.java:110)

liferay-continuous-integration · 2017-11-29T04:47:27Z

Some tests FAILED.

Build Time: 5 hours 44 minutes 36 seconds 658 ms

Base Branch:

Branch Name: master
Branch GIT ID: 4635e61e60b5148f95b8556527c40759de2b647c

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: b64a556caba29934851dbb46099ba311ddd6c0cc

108 out of 124 jobs PASSED

16 Failed Jobs:

108 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest(master)

Job Results:

108 Jobs Passed.
16 Jobs Failed.

	at org.apache.tools.ant.taskdefs.Sequential.execute(Sequential.java:68)
	at sun.reflect.GeneratedMethodAccessor71.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:497)
	at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
	at org.apache.tools.ant.Task.perform(Task.java:348)
	at net.sf.antcontrib.logic.TryCatchTask.execute(TryCatchTask.java:233)
	at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
	at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:497)
	at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
	at org.apache.tools.ant.Task.perform(Task.java:348)
	at org.apache.tools.ant.taskdefs.Sequential.execute(Sequential.java:68)
	at net.sf.antcontrib.logic.IfTask.execute(IfTask.java:197)
	at sun.reflect.GeneratedMethodAccessor28.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:497)
	at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
	at org.apache.tools.ant.TaskAdapter.execute(TaskAdapter.java:154)
	at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
	at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:497)
	at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
	at org.apache.tools.ant.Task.perform(Task.java:348)
	at org.apache.tools.ant.Target.execute(Target.java:435)
	at org.apache.tools.ant.Target.performTasks(Target.java:456)
	at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1393)
	at org.apache.tools.ant.Project.executeTarget(Project.java:1364)
	at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
	at org.apache.tools.ant.Project.executeTargets(Project.java:1248)
	at org.apache.tools.ant.Main.runBuild(Main.java:851)
	at org.apache.tools.ant.Main.startAnt(Main.java:235)
	at org.apache.tools.ant.launch.Launcher.run(Launcher.java:280)
	at org.apache.tools.ant.launch.Launcher.main(Launcher.java:109)

test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat80-mysql56-jdk8/0

Job Results:

2 Tests Passed.
2 Tests Failed.

AXIS_VARIABLE=0,label_exp=!master #184859

PortalLogAssertorTest.testScanXMLLog

java.io.IOException: org.xml.sax.SAXParseException; lineNumber: 4013; columnNumber: 89; An invalid XML character (Unicode: 0x1f) was found in the CDATA section.
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:173)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:100)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:90)
	at java.nio.file.Files.walkFileTree(Files.java:2670)
	at java.nio.file.Files.walkFileTree(Files.java:2742)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:88)
Caused by: org.xml.sax.SAXParseException; lineNumber: 4013; columnNumber: 89; An invalid XML character (Unicode: 0x1f) was found in the CDATA section.
	at org.apache.xerces.parsers.DOMParser.parse(Unknown Source)
	at org.apache.xerces.jaxp.DocumentBuilderImpl.parse(Unknown Source)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:123)

PortalSmoke#Smoke - Poshi Report - Poshi Summary - Console Output

test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-jboss70-mysql56-jdk8/2
Job Results:
1 Test Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #176769
  1. PortalSmokeUpgrade#ViewPortalSmokeArchive623 - Poshi Report - Poshi Summary - Console Output

test-portal-acceptance-pullrequest-batch(master)/modules-compile-jdk8

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #45290

     [exec] :test:external-data-source-test:jarSources
     [exec] :extractGradleApi25 UP-TO-DATE
     [exec] :sdk:gradle-plugins-node:compileJava
     [exec] :sdk:gradle-plugins-patcher:compileJava
     [exec] Note: Some input files use unchecked or unsafe operations.
     [exec] Note: Recompile with -Xlint:unchecked for details.
     [exec] :sdk:gradle-plugins-poshi-runner:compileJava
     [exec] Note: Some input files use unchecked or unsafe operations.
     [exec] Note: Recompile with -Xlint:unchecked for details.
     [exec] :sdk:gradle-plugins-service-builder:compileJava
     [exec] :sdk:gradle-plugins-poshi-runner:classes
     [exec] :sdk:gradle-plugins-poshi-runner:jar
     [exec] Note: /opt/dev/projects/github/liferay-portal/modules/sdk/gradle-plugins-patcher/src/main/java/com/liferay/gradle/plugins/patcher/PatchTask.java uses unchecked or unsafe operations.
     [exec] Note: Recompile with -Xlint:unchecked for details.
     [exec] :sdk:gradle-plugins-source-formatter:compileJava
     [exec] :sdk:gradle-plugins-patcher:compileGroovy UP-TO-DATE
     [exec] :sdk:gradle-plugins-patcher:classes
     [exec] :sdk:gradle-plugins-patcher:jar
     [exec] :sdk:gradle-plugins-soy:compileJava
     [exec] :sdk:gradle-plugins-source-formatter:classes
     [exec] Note: /opt/dev/projects/github/liferay-portal/modules/sdk/gradle-plugins-service-builder/src/main/java/com/liferay/gradle/plugins/service/builder/BuildServiceTask.java uses unchecked or unsafe operations.
     [exec] Note: Recompile with -Xlint:unchecked for details.
     [exec] :sdk:gradle-plugins-source-formatter:jar
     [exec] :sdk:gradle-plugins-service-builder:compileGroovy UP-TO-DATE
     [exec] :sdk:gradle-plugins-service-builder:classes
     [exec] Note: Some input files use unchecked or unsafe operations.
     [exec] Note: Recompile with -Xlint:unchecked for details.
     [exec] :sdk:gradle-plugins-service-builder:jar
     [exec] :sdk:gradle-plugins-node:compileGroovy UP-TO-DATE
     [exec] :sdk:gradle-plugins-node:classes
     [exec] Note: /opt/dev/projects/github/liferay-portal/modules/test/dependency-manager-integrity-test/src/testIntegration/java/com/liferay/dependency/manager/integrity/test/DependencyManagerIntegrityTest.java uses unchecked or unsafe operations.
     [exec] Note: Recompile with -Xlint:unchecked for details.
     [exec] :sdk:gradle-plugins-node:jar
     [exec] :sdk:gradle-plugins-test-integration:compileJava

test-portal-acceptance-pullrequest-batch(master)/modules-integration-db2105-jdk8

Job Results:

8449 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=6,label_exp=!master #45289

ConfigurationTemporarySwapperTest.testWillCleanUpConfiguration

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertFalse(Assert.java:64)
	at org.junit.Assert.assertFalse(Assert.java:74)
	at com.liferay.portal.configuration.test.util.test.ConfigurationTemporarySwapperTest.lambda$testWillCleanUpConfiguration$0(ConfigurationTemporarySwapperTest.java:77)
	at com.liferay.portal.configuration.test.util.test.ConfigurationTemporarySwapperTest.lambda$_callPersistenceManager$2(ConfigurationTemporarySwapperTest.java:207)
	at com.liferay.portal.osgi.util.test.OSGiServiceUtil.callService(OSGiServiceUtil.java:42)
	at com.liferay.portal.configuration.test.util.test.ConfigurationTemporarySwapperTest._callPersistenceManager(ConfigurationTemporarySwapperTest.java:204)
	at com.liferay.portal.configuration.test.util.test.ConfigurationTemporarySwapperTest.testWillCleanUpConfiguration(ConfigurationTemporarySwapperTest.java:66)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47...

...

gamerson · 2017-11-29T14:34:01Z

ci:stop

IDE-3359: Add Mojos for transpile and config

2ac02fa

christopherbryanboyd closed this Nov 28, 2017

christopherbryanboyd reopened this Nov 28, 2017

gamerson requested changes Nov 28, 2017

View reviewed changes

gamerson closed this Nov 29, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IDE-3359: Add Mojos for transpile and config #53

IDE-3359: Add Mojos for transpile and config #53

christopherbryanboyd commented Nov 28, 2017

liferay-continuous-integration commented Nov 28, 2017

gamerson left a comment

gamerson Nov 28, 2017

gamerson Nov 28, 2017

gamerson Nov 28, 2017

gamerson Nov 28, 2017

gamerson Nov 28, 2017

gamerson Nov 28, 2017

liferay-continuous-integration commented Nov 29, 2017

test-portal-acceptance-pullrequest-batch(master)/source-format-jdk8

Job Results:

liferay-continuous-integration commented Nov 29, 2017

16 Failed Jobs:

test-portal-acceptance-pullrequest(master)

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat80-mysql56-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-jboss70-mysql56-jdk8/2

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-compile-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-db2105-jdk8

Job Results:

gamerson commented Nov 29, 2017

IDE-3359: Add Mojos for transpile and config #53

IDE-3359: Add Mojos for transpile and config #53

Conversation

christopherbryanboyd commented Nov 28, 2017

liferay-continuous-integration commented Nov 28, 2017

gamerson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liferay-continuous-integration commented Nov 29, 2017

The pull request tester is still running.

However, the pull request was closed.

Critical Failure Details:

Job Results:

liferay-continuous-integration commented Nov 29, 2017

Some tests FAILED.

Base Branch:

Copied in Private Modules Branch:

16 Failed Jobs:

For more details click here.

Failures unique to this pull:

Job Results:

Job Results:

Job Results:

Job Results:

Job Results:

gamerson commented Nov 29, 2017