Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enrico/RunGtlike.py should not be a command line tool #45

Open
cdeil opened this issue Sep 21, 2013 · 3 comments
Open

enrico/RunGtlike.py should not be a command line tool #45

cdeil opened this issue Sep 21, 2013 · 3 comments
Assignees
Labels
Milestone

Comments

@cdeil
Copy link
Contributor

cdeil commented Sep 21, 2013

It's cleaner if library code and command line scripts are separated.

Therefore I suggest to remove the if __name__ == '__main__': part from enrico/RunGTlike.py.

If I see correctly the only place where RunGTlike.py is used as a command line tool is in enrico.energybin.RunEbin?

In that case we could simply call enrico.RunGTlike.run() there instead of calling RunGTlike.py as a command line tool?

@davidsanchez If you agree I think I could quickly make the change.

@cdeil
Copy link
Contributor Author

cdeil commented Sep 21, 2013

I just saw: enrico/appertureLC.py currently is also a command line tool that is called from bin/enrico_applc. Same cleanup could be done here.

@davidsanchez
Copy link
Member

I will have a look

@davidsanchez
Copy link
Member

I don't know how to do that. RunGTlike is call when submitting a job and need to be call in a command line

@ghost ghost assigned cdeil Sep 23, 2013
@cdeil cdeil modified the milestones: 0.2, 0.3 Sep 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants