Adapt SkyModel to evaluate on TimeMapAxis

[AtreyeeS]

Addresses remaining part of #4480 - adapt SkyModel.evaluate_geom() and SkyModel.integrate_geom() to work with a TimeMapAxis

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2c58cf3) 75.80% compared to head (38e3281) 75.83%.
Report is 66 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4828      +/-   ##
==========================================
+ Coverage   75.80%   75.83%   +0.03%     
==========================================
  Files         227      227              
  Lines       33315    33401      +86     
==========================================
+ Hits        25255    25331      +76     
- Misses       8060     8070      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[AtreyeeS]

I have adapted SkyModel.evaluate_geom to support a TimeMapAxis.
Support for integrate_geom needs #4859 to be addressed

This has the loop over axis bins, which is not nice. Any better suggestion will be much appreciated.

The nice thing is this can allow FluxPointsDataset to work with n-dim geom. For eg, fitting light curves need not go through the splitting into multiple datasets for each time bin.

Maybe we can merge this now, and I can adapt the FluxPointsDataset after this?
The integrate_geom functionality is more necessary for MapEvaluator, which is not planned to be supported at the moment

[registerrier]

Hi @AtreyeeS , #4859 has been merged. Could you rebase?

[AtreyeeS]

After rebasing, I adapt SkyModel.integrate_geom() as well.
#4480 can be closed once this PR is merged.

[QRemy]

Thanks @AtreyeeS, looks good, I just pushed a commit to reduce code duplication and left one question :

[Astro-Kirsty]

Thanks @AtreyeeS