Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TablePSFChecker #763

Merged
merged 1 commit into from Nov 10, 2016
Merged

Add TablePSFChecker #763

merged 1 commit into from Nov 10, 2016

Conversation

dltiziani
Copy link
Contributor

A script for testing the table PSF is added.
The following checks are implemented:

  • NaN entries within safe energy threshold?
  • integral of PSF equals 1?
  • relative difference of containment radii of neighboring energy/offset bins exceeds a threshold?

@cdeil cdeil added the feature label Nov 10, 2016
@cdeil cdeil added this to the 0.5 milestone Nov 10, 2016
@cdeil cdeil self-assigned this Nov 10, 2016
@cdeil cdeil changed the title Table PSF check script Add TablePSFChecker Nov 10, 2016
@cdeil
Copy link
Contributor

cdeil commented Nov 10, 2016

@dltiziani - Thanks!

This will need tests and also docs / code improvements.

But it's better to have this available for everyone in master, and do those in future PRs whenever someone has time. So I'm merging this now.

@cdeil cdeil merged commit c5a856d into gammapy:master Nov 10, 2016
@cdeil cdeil mentioned this pull request Nov 10, 2016
Merged
5 tasks
@cdeil cdeil mentioned this pull request May 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cdeil cdeil

Labels
feature
Projects
None yet
Milestone
0.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dltiziani @cdeil