Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ScaledRegularGridInterpolator #1855

Merged
merged 20 commits into from
Oct 4, 2018
Merged

Add ScaledRegularGridInterpolator #1855

merged 20 commits into from
Oct 4, 2018

Conversation

adonath
Copy link
Member

@adonath adonath commented Oct 4, 2018 •
edited
Loading

This PR introduces a ScaledRegularGridInterpolator as a thin wrapper around Scipy's RegularGridInterpolator, that scales the values before the interpolation. This is also a fix for #1842.

Here is a notebook with a check notebook, that shows the background norm comes out nicely.

@adonath adonath added the feature label Oct 4, 2018
@adonath adonath self-assigned this Oct 4, 2018
@cdeil cdeil changed the title Introduce ScaledRegularGridInterpolator object Add ScaledRegularGridInterpolator Oct 4, 2018
@cdeil cdeil added this to the 0.9 milestone Oct 4, 2018
cdeil
cdeil approved these changes Oct 4, 2018
View reviewed changes
Copy link
Contributor

@cdeil cdeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@cdeil cdeil merged commit 993b382 into gammapy:master Oct 4, 2018
@adonath adonath mentioned this pull request Oct 5, 2018
Closed
@registerrier registerrier mentioned this pull request Oct 9, 2018
Closed
@AtreyeeS AtreyeeS mentioned this pull request Oct 9, 2018
Closed
@registerrier registerrier mentioned this pull request Oct 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdeil cdeil cdeil approved these changes

Assignees

@adonath adonath

Labels
feature
Projects
None yet
Milestone
0.9
Development

Successfully merging this pull request may close these issues.
2 participants
@adonath @cdeil