Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ScaledRegularGridInterpolator #1855

Merged
merged 20 commits into from Oct 4, 2018
Merged

Conversation

@adonath
Copy link
Member

@adonath adonath commented Oct 4, 2018

This PR introduces a ScaledRegularGridInterpolator as a thin wrapper around Scipy's RegularGridInterpolator, that scales the values before the interpolation. This is also a fix for #1842.

Here is a notebook with a check notebook, that shows the background norm comes out nicely.

@adonath adonath added the feature label Oct 4, 2018
@adonath adonath self-assigned this Oct 4, 2018
@cdeil cdeil changed the title Introduce ScaledRegularGridInterpolator object Add ScaledRegularGridInterpolator Oct 4, 2018
@cdeil cdeil added this to the 0.9 milestone Oct 4, 2018
@cdeil cdeil added this to To do in gammapy.irf via automation Oct 4, 2018
@cdeil
cdeil approved these changes Oct 4, 2018
Copy link
Member

@cdeil cdeil left a comment

Looks good. Thank you!

@cdeil cdeil merged commit 993b382 into gammapy:master Oct 4, 2018
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Scrutinizer Analysis: 12 new issues, 12 updated code elements – Tests: passed
Details
gammapy.irf automation moved this from To do to Done Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
gammapy.irf
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants