Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ReflectedRegionsFinder class #2089

Merged
merged 41 commits into from
Jun 26, 2019
Merged

Improve ReflectedRegionsFinder class #2089

merged 41 commits into from
Jun 26, 2019

Commits on Jun 24, 2019

  1. Modify Reflected Region Background class to support multiple ON regio… 

    …ns shapes
    @registerrier
    Bruno Khelifi authored and registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    6bd4f4b View commit details
    Browse the repository at this point in the history

  2. Add new tutorial to explain new usage

    @registerrier
    Bruno Khelifi authored and registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    ceb48ed View commit details
    Browse the repository at this point in the history

  3. Add new tutorial to explain new usage

    @registerrier
    Bruno Khelifi authored and registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    b3956b5 View commit details
    Browse the repository at this point in the history

  4. Change the name of the dictionnary

    @registerrier
    Bruno Khelifi authored and registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    236e2e9 View commit details
    Browse the repository at this point in the history

  5. Remove the map and use only the WcsGeom

    @registerrier
    Bruno Khelifi authored and registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    8af42cd View commit details
    Browse the repository at this point in the history

  6. Bet management of the bining size

    @registerrier
    Bruno Khelifi authored and registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    0da6abe View commit details
    Browse the repository at this point in the history

  7. Some corrections on make_reference_map

    @registerrier
    registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    9bc6b66 View commit details
    Browse the repository at this point in the history

  8. Further corrections on make_reference_map

    @registerrier
    registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    1d7c917 View commit details
    Browse the repository at this point in the history

  9. Removed useless reprojection

    @registerrier
    registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    faca92d View commit details
    Browse the repository at this point in the history

  10. Further changes

    @registerrier
    registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    e1b933c View commit details
    Browse the repository at this point in the history

  11. additional changes

    @registerrier
    registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    5cac246 View commit details
    Browse the repository at this point in the history

  12. Remove the print function for the log functions

    @registerrier
    Bruno Khelifi authored and registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    af395bc View commit details
    Browse the repository at this point in the history

  13. Update the code after the fix on the mask maps

    @registerrier
    Bruno Khelifi authored and registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    f6e845a View commit details
    Browse the repository at this point in the history

  14. Simplification based on the CDeil's suggestion

    @registerrier
    Bruno Khelifi authored and registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    65a3589 View commit details
    Browse the repository at this point in the history

  15. Further mods

    @registerrier
    registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    b0cd777 View commit details
    Browse the repository at this point in the history

  16. Minor updates

    @registerrier
    registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    f56d4ee View commit details
    Browse the repository at this point in the history

  17. Moved warnings to ReflectedRegionsBackgroundEstimator

    @registerrier
    registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    560c892 View commit details
    Browse the repository at this point in the history

  18. Changed reference map width to 4 times the separation between center … 

    …and pointing position
    @registerrier
    registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    17d8aba View commit details
    Browse the repository at this point in the history

  19. Moved copy and rotate outside ReflectedRegionFinder

    @registerrier
    registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    d0d5428 View commit details
    Browse the repository at this point in the history

  20. Moved copy and rotate outside ReflectedRegionFinder

    @registerrier
    registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    2cfcf37 View commit details
    Browse the repository at this point in the history

  21. Removed some logs

    @registerrier
    registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    ca5675a View commit details
    Browse the repository at this point in the history

  22. Change wrap command for minimal angular size of a region

    @registerrier
    registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    1786cea View commit details
    Browse the repository at this point in the history

  23. Code clean-up and re-organization

    @registerrier
    registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    3130dad View commit details
    Browse the repository at this point in the history

  24. code clean-up and new test addition

    @registerrier
    registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    6072d3b View commit details
    Browse the repository at this point in the history

  25. Simplified plot function

    @registerrier
    registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    26c138f View commit details
    Browse the repository at this point in the history

  26. Changed the code to use .rotate() from regions v0.4

    @registerrier
    registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    e5aaaff View commit details
    Browse the repository at this point in the history

  27. colorbar range for empty masks plot

    @registerrier
    registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    745c446 View commit details
    Browse the repository at this point in the history

  28. Modified tests for spectrum_extract and lightcurve to adapt for small… 

    … change in selected event number. This change is likely due to the filtering with a mask compared to filtering with distance to the region center
    @registerrier
    registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    3cbd371 View commit details
    Browse the repository at this point in the history

  29. Improve documentation of reflected regions

    @registerrier
    registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    2753611 View commit details
    Browse the repository at this point in the history

  30. Added example using rectangular region

    @registerrier
    registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    156a908 View commit details
    Browse the repository at this point in the history

  31. Added link to notebook

    @registerrier
    registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    0148d5c View commit details
    Browse the repository at this point in the history

  32. Modified reference to notebook

    @registerrier
    registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    3bf44d5 View commit details
    Browse the repository at this point in the history

  33. Remove notebook

    @registerrier
    registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    031c0f8 View commit details
    Browse the repository at this point in the history

  34. Updated setup.py to include regions v0.4

    @registerrier
    registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    884f12a View commit details
    Browse the repository at this point in the history

  35. Check if pointing is inside ON_region

    @registerrier
    registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    e438182 View commit details
    Browse the repository at this point in the history

  36. Updated to use select_region

    @registerrier
    registerrier committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    6a4ec2d View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2019

  1. check

    @registerrier
    registerrier committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    984f92a View commit details
    Browse the repository at this point in the history

  2. Adapted tests

    @registerrier
    registerrier committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    b02c12b View commit details
    Browse the repository at this point in the history

  3. Removed improper log warning

    @registerrier
    registerrier committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    874ca43 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2019

  1. Further clean-up and addition of tests for bad region and non-circula… 

    …r ones
    @registerrier
    registerrier committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    28ba9dd View commit details
    Browse the repository at this point in the history

  2. Clean reflected regions code

    @cdeil
    cdeil committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    5724d4f View commit details
    Browse the repository at this point in the history