Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ObservationStats, ObservationsSummary and BackgroundEstimate #2502

Merged
merged 14 commits into from Oct 31, 2019

Conversation

@adonath
Copy link
Member

adonath commented Oct 31, 2019

This PR removes the following classes:

  • ObservationStats
  • ObservationSummary
  • BackgroundEstimate
  • ReflectedRegionsBackgroundEstimator

The functionality is kept by:

  • Extend info in SpectrumDatasetOnOff.info_dict() by alpha, significance etc.
  • Add Datasets.info_table() which collects all the info from the contained datasets (currently only supported for SpectrumDatasetOnOff). In addition one can specify, whether the info is stacked cumulatively.

ToDo:

  • Add unit tests for SpectrumDatasetOnOff.info_dict()
  • Add unit tests for Dataset.info_table()
@adonath adonath self-assigned this Oct 31, 2019
@adonath adonath added the cleanup label Oct 31, 2019
@adonath adonath added this to the 0.15 milestone Oct 31, 2019
@cdeil

This comment has been minimized.

Copy link
Member

cdeil commented Oct 31, 2019

@adonath

This comment has been minimized.

Copy link
Member Author

adonath commented Oct 31, 2019

The remaining Travis fail is unrelated. Will go ahead and merge...

@adonath adonath merged commit b46859b into gammapy:master Oct 31, 2019
8 of 9 checks passed
8 of 9 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: 4 updated code elements – Tests: passed
Details
gammapy.gammapy Build #20191031.15 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.