New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to perform summary of merged PRs and closed issues #4125
Conversation
@registerrier Be default I included the dev scripts in the CI check as well, just because they don't change often. However I'm not sure the dev scripts are included in the pre-commit hook. Maybe you can check and adapt the PR... |
Codecov Report
@@ Coverage Diff @@
## main #4125 +/- ##
=======================================
Coverage 94.96% 94.96%
=======================================
Files 221 221
Lines 31445 31445
=======================================
Hits 29862 29862
Misses 1583 1583
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
It is included in the pre-commit hooks. I was not executing them :). |
Thanks @registerrier, great implementation.
|
6b632a0
to
2b40998
Compare
It would be good to have something like this, but we should try to improve the implementation. |
2b40998
to
c518034
Compare
…given milestone Signed-off-by: Régis Terrier <rterrier@apc.in2p3.fr>
Signed-off-by: Régis Terrier <rterrier@apc.in2p3.fr>
Signed-off-by: Régis Terrier <rterrier@apc.in2p3.fr>
Signed-off-by: Régis Terrier <rterrier@apc.in2p3.fr>
Signed-off-by: Régis Terrier <rterrier@apc.in2p3.fr>
Signed-off-by: Régis Terrier <rterrier@apc.in2p3.fr>
Signed-off-by: Régis Terrier <rterrier@apc.in2p3.fr>
Signed-off-by: Régis Terrier <rterrier@apc.in2p3.fr>
Signed-off-by: Régis Terrier <rterrier@apc.in2p3.fr>
Signed-off-by: Régis Terrier <rterrier@apc.in2p3.fr>
6569e7d
to
8793690
Compare
The code has been completely changed. It now consists in a a general class It is called this way:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @registerrier, I have no comments! This is a very useful and cleanly written script!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @registerrier !
dev/github_summary.py
Outdated
return result | ||
|
||
def extract_pull_requests_table( | ||
self, state="closed", number_min=0, include_backports=False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github counts from 1, so I guess the default number_min = 1
… and closed issues
…5-on-v1.1.x Backport PR #4125 on branch v1.1.x (Add script to perform summary of merged PRs and closed issues )
Description
This pull request proposes a script to query the GitHub list of closed PRs and issues to list all merged PRs and count closed issues with a given milestone.
Usage:
It requires to install PyGithub (https://github.com/PyGithub/PyGithub)
Dear reviewer