adding weights option to fill_events #4458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxime Regeard <regeard@apc.in2p3.fr>
Signed-off-by: Maxime Regeard <regeard@apc.in2p3.fr>
Codecov Report
@@ Coverage Diff @@
## main #4458 +/- ##
==========================================
+ Coverage 94.87% 94.93% +0.05%
==========================================
Files 216 218 +2
Lines 30626 30888 +262
==========================================
+ Hits 29057 29322 +265
+ Misses 1569 1566 -3
... and 45 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks @MRegeard! I'm not sure we would really like to expose this, where we explicitly refer to "events" (see my comment ). What do you think @registerrier ? |
Signed-off-by: Maxime Regeard <regeard@apc.in2p3.fr>
Signed-off-by: Maxime Regeard <regeard@apc.in2p3.fr>
registerrier
reviewed
Apr 7, 2023
There was a problem hiding this comment.
Thanks @MRegeard . Looks good. Please a a test for this new functionality.
Signed-off-by: Maxime Regeard <regeard@apc.in2p3.fr>
registerrier
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is related to #4457.
I added a weights option to
Map.fill_events. SinceMap.fill_eventsusesMap.fill_by_coordwhich has a weights option, the implementation is straight forward.