-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust getting-started page #4983
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4983 +/- ##
==========================================
- Coverage 75.41% 75.23% -0.18%
==========================================
Files 230 234 +4
Lines 34122 34845 +723
==========================================
+ Hits 25733 26216 +483
- Misses 8389 8629 +240 ☔ View full report in Codecov by Sentry. |
Since we have a few dependencies in the explicit pip channel of the environment file, I moved sherpa in this section so that we don't need the note on sherpa with Apple Silicon in the quickstart page of the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Astro-Kirsty for this useful set of adjustments!
Thanks @Astro-Kirsty! Can you locally build the documentation and push a preview to your GitHub? I did this in the past e.g. here: https://github.com/adonath/gammapy-docs-preview It should work like: make docs-sphinx
cp -r docs/_build/html path-to/gammapy-docs-preview Then we can access the docs online at |
I've made the repo, here is the link for the docs https://astro-kirsty.github.io/gammapy-docs-preview/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Astro-Kirsty ! Looking at your generated docs page, the instructions on the "most common way" ie, https://docs.gammapy.org/dev/getting-started/index.html#quickstart-setup are a bit hidden.
Your QuickStart
section only shows how to install the data and tutorials https://astro-kirsty.github.io/gammapy-docs-preview/getting-started/index.html#quickstart-setup
I would propose you can simply rename QuickStart
to Recommended SetUp
, which should make it clearer, no?
Thanks @AtreyeeS, I adjusted it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Astro-Kirsty . The page seems intuitive and easy to read for me now. No further comments from me
Signed-off-by: Astro-Kirsty <AstroKirsty@gmail.com>
Signed-off-by: Maxime Regeard <regeard@apc.in2p3.fr>
Signed-off-by: Maxime Regeard <regeard@apc.in2p3.fr>
Signed-off-by: Astro-Kirsty <AstroKirsty@gmail.com>
0692bf9
to
5377856
Compare
Signed-off-by: Astro-Kirsty <AstroKirsty@gmail.com>
Signed-off-by: Astro-Kirsty <AstroKirsty@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Astro-Kirsty, this looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Astro-Kirsty . I am not sure I understand why you removed the instructions for the creation of the environment in the recommended setup. It is no longer visible from the main page then, no?
It was according to #4838. If you think it would be best to change it back, let us know! |
Also, there is no mention of mamba. Is it intended? |
The lates versions of conda include the mamba solver. I'm not sure it is needed anymore. |
mamba is not mentioned on the initial page but is mentioned in "installation" where a full guide of how to install is included. |
What is the current opinion here? Can we merge? |
What would be the conflicts with #5113 ? |
No major conflict. That changes the 'Installation' description, which can be adjusted once this PR has been merged. |
We discussed this PR during one of the last dev calls, but were not sure if the present preview of the docs on your GitHub was the latest version. Reviewing is a bit difficult without seeing how it renders finally. |
I wouldn't have been in the call. |
Hi @Astro-Kirsty,
and redirect user to the Because currently this part of the page only shows how to download the tutorials and datasets, and furthermore assume a conda environment (without showing how to create one). I think installation with in an environment should appear in this page ! |
Good idea @MRegeard! |
Signed-off-by: Astro-Kirsty <AstroKirsty@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok from my side (please see inline question about specific instructions to windows users)
@adonath can you comment once if the instructions about conda environments are okay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Astro-Kirsty, I have left some comments.
Signed-off-by: Astro-Kirsty <AstroKirsty@gmail.com>
Signed-off-by: Astro-Kirsty <AstroKirsty@gmail.com>
This PR should be ready for final review with changes as per the dev call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Astro-Kirsty this final version looks nice to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @Astro-Kirsty, no further comments from my side!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @Astro-Kirsty !
Description
This PR is to resolve #4838. It adjusts the
Getting started
page to be far more simple and realistic to how we would typically install gammapy.Then the other pages (
Installation
,Virtual Environments
etc) are adjusted accordingly.https://astro-kirsty.github.io/gammapy-docs-preview/