-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose FitResult
#5255
Expose FitResult
#5255
Conversation
Because this PR expose this class, I am wondering whether one should not describe the content of the FitResult class in the main docstring.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Astro-Kirsty .
Yes the docstring should give the correct info. This probably means that OptimizeResult
and CovarianceResult
need to be exposed too...
Regarding writing the FitResult
to disc, we should check that we can fit everything in a yaml file. I suppose this is the easiest solution for this. This might be a second PR.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5255 +/- ##
==========================================
- Coverage 75.27% 75.23% -0.05%
==========================================
Files 234 234
Lines 35148 35181 +33
==========================================
+ Hits 26458 26467 +9
- Misses 8690 8714 +24 ☔ View full report in Codecov by Sentry. |
FitResult
and add an option to write it to fileFitResult
Signed-off-by: Astro-Kirsty <AstroKirsty@gmail.com>
Signed-off-by: Astro-Kirsty <AstroKirsty@gmail.com>
9bce4b2
to
012281a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Astro-Kirsty, I have only a minor comment about the change in the Registry class :
Signed-off-by: Astro-Kirsty <AstroKirsty@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Astro-Kirsty, no further comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Astro-Kirsty . Looks good!
Description
This PR is to resolve #5154