-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow extrapolation only along spatial dimension in mask_safe_edisp
#5271
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5271 +/- ##
==========================================
- Coverage 94.47% 94.46% -0.01%
==========================================
Files 235 232 -3
Lines 35574 35636 +62
==========================================
+ Hits 33608 33664 +56
- Misses 1966 1972 +6 ☔ View full report in Codecov by Sentry. |
Hi @QRemy, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @QRemy. This is a nice solution.
Signed-off-by: Quentin Remy <quentin.remy@mpi-hd.mpg.de>
Signed-off-by: Quentin Remy <quentin.remy@mpi-hd.mpg.de>
Signed-off-by: Quentin Remy <quentin.remy@mpi-hd.mpg.de>
61a26d9
to
bf5b0e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks @QRemy
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
…nsion in `mask_safe_edisp`
…1-on-v1.2.x Backport PR #5271 on branch v1.2.x (Allow extrapolation only along spatial dimension in `mask_safe_edisp`)
…n `mask_safe_edisp` Signed-off-by: Quentin Remy <quentin.remy@mpi-hd.mpg.de>
Backport PR #5271: Allow extrapolation only along spatial dimension in `mask_safe_edisp`
Support for extrapolation in
interp_to_geom
if geom is mask.Allow extrapolation only along spatial dimension in
mask_safe_edisp
to support case where
mask_safe
geom and irfs geom are different.This a better solution to resolve the problem described in #5236.