This is the third part of the major SkyCube rework. These are the most important changes in this PR:
Move stand-alone convolve_cube function to SkyCube.convolve()
Move stand-alone cube_to_spec function to SkyCube.to_spectrum, but currently not working.
Add a EnergyDependentTablePSF.kernels() method to get a set of kernels for cube convolution
Rewrite compute_npred_cube function
When running the script docs/tutorials/npred/npred_convolved.py , I get very good agreement with the result from the fermi science tools. The total number of counts agrees within >1%, depending on the precision of the flux image integration.
Return copy for data and wcs, at least by default, to avoid accidentally coupled objects?
(I thought we had that method already, didn't review the SkyCube class again. Just ignore me if this is not a good suggestion)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.