Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Warning on VM creation without password #5

Closed
webcracy opened this issue Sep 10, 2014 · 17 comments
Closed

Warning on VM creation without password #5

webcracy opened this issue Sep 10, 2014 · 17 comments

Comments

@webcracy
Copy link
Contributor

When $ gandi vm create is ran without a password, we get this message:

/!\ Please be aware that you did not provide a password, some services like console will not be able to work.

It might be nicer instead to display the VM's config and other details such as:

  • root and admin users will be created
  • SSH key authorization will be used
  • No password was supplied (Warning: emergency console access from the web interface is disabled)

WDYT?

@kalou
Copy link
Contributor

kalou commented Sep 10, 2014

On Wed, 2014-09-10 at 06:36 -0700, Alexandre Loureiro Solleiro wrote:

When $ gandi vm create is ran without a password, we get this message:

/!\ Please be aware that you did not provide a password, some services like console will not be able to work.

It might be nicer instead to display the VM's config and other details
such as:

  * root and admin users will be created
  * SSH key authorization will be used
  * No password was supplied (Warning: emergency console access
    from the web interface is disabled)

I believe I'm guilty here. There used to be a full detailed output about
the vm config and I asked for a smaller and clearer output. Maybe add
just the required, non obvious details ?

@webcracy
Copy link
Contributor Author

@kalou I think I like the whole output better, but minimal non obvious info seems like a good compromise.

@sayoun
Copy link
Contributor

sayoun commented Sep 10, 2014

Yes I removed the verbose output at kalou's request but it's still available using -v options:
$ gandi -v vm create

I think minimal but non obvious is the way to go, is @webcracy proposal ok with you @kalou ?

@kalou
Copy link
Contributor

kalou commented Sep 10, 2014

Provided -v exists, I think we really should stick to minimal information then. What's eligible ?

@sayoun
Copy link
Contributor

sayoun commented Sep 10, 2014

I don't think we should output raw values like -v do, @webcracy proposal seems ok to me.
We should make user friendly output to warn the user but no frighten him.

I don't see anything to add to the above list, except maybe a brief summary of vm specs and hostname reminder ? like:
configuration used: 2 cores, 256Mb memory, ipv4/6 enabled, hostname: docker

@sayoun
Copy link
Contributor

sayoun commented Sep 11, 2014

Ok I've changed to have this:

$ gandi vm create --login hordax
* root and hordax users will be created.
* SSH key authorization will be used.
* No password was supplied (Warning: emergency console access from the web interface is disabled).
* Configuration used: 1 cores, 256Mb memory, ip v4, image Debian 7, hostname: temp1410423975
Creating your Virtual Machine.
Progress: [####----------------------------------------] 11.11%  00:00:18`

is it ok for you @kalou and @webcracy ?

@kalou
Copy link
Contributor

kalou commented Sep 11, 2014

On Thu, 2014-09-11 at 01:31 -0700, Dejan Filipovic wrote:

Ok I've changed to have this:

$ gandi vm create --login hordax

  • root and hordax users will be created.
  • SSH key authorization will be used.
  • No password was supplied (Warning: emergency console access from the web interface is disabled).
  • Configuration used: 1 cores, 256Mb memory, ip v4, image Debian 7, hostname: temp1410423975
    Creating your Virtual Machine.
    Progress: [####----------------------------------------] 11.11% 00:00:18`

Looks ok to me on the contents

I think "emergency console access from the web interface is disabled"
does not reflect the password missing cause enough

Also is this example showing ipv4 only normal ?

@sayoun
Copy link
Contributor

sayoun commented Sep 11, 2014

I used default configuration during tests and it uses ip_version 4. But I think you want to display ipv4+v6 and not juste ip v4 as we always create an ipv6 for all ipv4, but not the otherway around.

@kalou
Copy link
Contributor

kalou commented Sep 11, 2014

On Thu, 2014-09-11 at 02:07 -0700, Dejan Filipovic wrote:

I used default configuration during tests and it uses ip_version 4.
But I think you want to display ipv4+v6 and not juste ip v4 as we
always create an ipv6 for all ipv4, but not the otherway around.

yes - the question was stupid but my intent was to ask for v4/v6
output ;)

@webcracy
Copy link
Contributor Author

I like it and think ipv6 will be a nice addition as well.

As for a better wording for the emergency web console, how about:
No password supplied for user login (required to enable emergency web console access).

@sayoun
Copy link
Contributor

sayoun commented Sep 11, 2014

Seems ok to me @webcracy, I changed to display this now:

$ gandi vm create --login hordax
* root and hordax users will be created.
* SSH key authorization will be used.
* No password supplied for user hordax (required to enable emergency web console access).
* Configuration used: 1 cores, 256Mb memory, ip v4+v6, image Debian 7, hostname: temp1410440049
Creating your Virtual Machine.

if ip_version value is 6, it will only display ip v6 in message.

@kalou
Copy link
Contributor

kalou commented Sep 11, 2014

sorry to pinailler ;) but .. "No password was supplied for vm" != for user, even though we use the same for both purposes. One should be able to specify a password with no user.

@webcracy
Copy link
Contributor Author

👍 indeed, thanks for pinailling :)

@sayoun
Copy link
Contributor

sayoun commented Sep 11, 2014

Ok I'll change this but we always create a default user in CLI (default value to 'admin'), maybe it's a bug ?

@kalou
Copy link
Contributor

kalou commented Sep 11, 2014

The API login parameter is optional with no default, and we use the password for root and the vm object itself - so I believe this could be optioned-out safely.

@sayoun
Copy link
Contributor

sayoun commented Sep 11, 2014

Ok i'll also change this then.

@sayoun
Copy link
Contributor

sayoun commented Sep 12, 2014

Made login parameter optional with no default, and commited and fixed summary displayed before vm creation. Closing this issue.

@sayoun sayoun closed this as completed Sep 12, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants