Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Won't work? #26

Closed
exalted opened this issue Feb 27, 2015 · 8 comments
Closed

Won't work? #26

exalted opened this issue Feb 27, 2015 · 8 comments

Comments

@exalted
Copy link

exalted commented Feb 27, 2015

Hi,

sorry for such a lazy title, but hopefully here's more insight to it:

  • Atom Version 0.184.0 (0.184.0)
  • incremental-search 4.2.0
  • Mac OS X 10.10.2

Although cmd-i will popup the incremental search box below the editor area, when I hit keys on my keyboard nothing will happen (meaning not that it won't actually find anything, but pressed keys won't even appear on the search/find field).

Any ideas?

Thank you.

@lodestone
Copy link

+1

I am having this same issue. Pretty much all the same stats. OSX 10.10.2, Inc Search 4.2, Atom Vers 0.185...

I don't even know where to begin trying to debug why this is happening.

@edsko
Copy link

edsko commented Feb 28, 2015

Confirmed. This broke somewhere between Atom 0.182 and 0.184.

@edsko
Copy link

edsko commented Feb 28, 2015

This seems to be affecting other packages as well; see bradens/atom-pipe#7 for instance.

@jeduan
Copy link

jeduan commented Mar 5, 2015

👍

@exalted
Copy link
Author

exalted commented Apr 19, 2015

Weird. I see this package gets updated, but still not working. Is increment search working to some and not to others?

@nwinkler
Copy link

The search is working for me, but I don't see any of the typed characters in the incremental search text field.

Atom 0.194.0
Incremental Search 4.3.0

@exalted
Copy link
Author

exalted commented May 29, 2015

@gangstead closed, because it’s fixed or not interested or what please?

@gangstead
Copy link
Owner

I just inherited the project and bulk closed all the open issues. Allow me to explain my reasoning:

The package has been losing functionality as it stagnates while Atom marches forward. I've been making changes to remove the deprecations before the API 1.0 cutoff on 6/1/15 or else the package will be blocked from loading. Some are fixed, but it's not done yet. I suspect fixing all the Atom API issues will resolve most of the issues I just closed (hopefully without introducing new ones!). Your issue might be fixed by then, if not feel free to reopen/create a new one, but please be patient.

With this first round of deprecation fixes v4.4.0 on Atom 0.204.0 I restored basic open search box and searches advance while you type functionality. Past that it is still throwing some exceptions as a lot of the package needs to be overhauled.

Thanks for your interest in the package. Submitting issues is a big help, that's how I got started. I'm doing this as a labor of love in my spare time and would love to have more contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants