Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To support debian #30

Merged
merged 4 commits into from
Sep 29, 2018
Merged

To support debian #30

merged 4 commits into from
Sep 29, 2018

Conversation

rzr
Copy link
Collaborator

@rzr rzr commented Nov 7, 2016

Tested with device (thx)

Better use system ones

Signed-off-by: Philippe Coval <rzr@gna.org>
Signed-off-by: Philippe Coval <rzr@gna.org>
Signed-off-by: Philippe Coval <rzr@gna.org>
Signed-off-by: Philippe Coval <rzr@gna.org>
@rzr
Copy link
Collaborator Author

rzr commented Jan 23, 2018

I am considering to merge this is anyone against ?

@ganzziani
Copy link
Owner

I don't have a Linux environment to check this... what is it about? Just configuration to build on debian?

@rzr
Copy link
Collaborator Author

rzr commented Jan 24, 2018

those are patches I created to make debian integration easier
there is no packaging files here

@rzr
Copy link
Collaborator Author

rzr commented Aug 17, 2018

i can share docker files to replicate

@ganzziani ganzziani merged commit a08f898 into ganzziani:master Sep 29, 2018
@HomeACcessoryKid
Copy link

A side effect of the deletion of lib/unix is that the mac does not compile anymore!
This is because a mac is both macs and unix at the same time

Then the line in XprotolabInterface.pro

unix: LIBS += -L$$PWD/libs/unix -lusb-1.0

ends up with the error:

ld: warning: directory not found for option '-L/Users/hack/Documents/microControl/xprotolab/xscopes-qt/libs/unix'
ld: library not found for -lusb-1.0
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [xscope.app/Contents/MacOS/xscope] Error 1

where previously it would escape with this warning:

ld: warning: ignoring file /Users/hack/Documents/microControl/xprotolab/xscopes-qt/libs/unix/libusb-1.0.a, file was built for archive which is not the architecture being linked (x86_64): /Users/hack/Documents/microControl/xprotolab/xscopes-qt/libs/unix/libusb-1.0.a

Can you adjust somehow to fix this??
My personal workaround is to prefix that unix line with a #

@rzr
Copy link
Collaborator Author

rzr commented Sep 30, 2018

Can't we specify for darwin ?

@HomeACcessoryKid
Copy link

I am not actually familiar with QT but can make experiments.
What exactly do you suggest gets changed?
Yet I am sceptical since it looks like macOS claims to be macx and unix at the same time...
How can I find out all the things that it claims to be?
And as a counter question, why do you have a line called "unix:"
can that not be turned into Linux: ?

@rzr
Copy link
Collaborator Author

rzr commented Sep 30, 2018

Please review:
#37

@HomeACcessoryKid
Copy link

see comment at #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants