Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add local lib path for darwin and windows #37

Merged
merged 2 commits into from
Oct 14, 2018

Conversation

rzr
Copy link
Collaborator

@rzr rzr commented Sep 30, 2018

In longer term it would make sense to remove those libs
and use system's ones like linux

Change-Id: I6399b9715b245c2cc11828a0f3bb8f825f72c0c3
Bug: #36
Signed-off-by: Philippe Coval rzr@users.sf.net

In longer term it would make sense to remove those libs
and use system's ones like linux

Change-Id: I6399b9715b245c2cc11828a0f3bb8f825f72c0c3
Bug: ganzziani#36
Signed-off-by: Philippe Coval <rzr@users.sf.net>
@rzr rzr mentioned this pull request Sep 30, 2018
@HomeACcessoryKid
Copy link

this does not work since the line in XprotolabInterface.pro line 45 still contains the invocation for unix and will give the error described in #30

@rzr
Copy link
Collaborator Author

rzr commented Oct 6, 2018

Arent you using cmake at all ?

I am septical about linking linux binaries to darwin ones :)

It may replaced with pkg-config, but I prefer to use cmake

Bug: ganzziani#37
Change-Id: I09dac4359749131978f1349e9e2b76ca9e690d2b
Signed-off-by: Philippe Coval <p.coval@samsung.com>
@HomeACcessoryKid
Copy link

Message 1: it works with your proposal

Message 2: the instructions I found and that seem to work for me are like this:

2) install qt and libusb: brew install qt libusb
3) get xscopes' sources: git clone https://github.com/ganzziani/xscopes-qt.git
4) change into the cloned dir: cd xscopes-qt
5) export PATH="/usr/local/opt/qt/bin:$PATH"
6) compile: qmake && make

So, no, that does not include cmake

like I said, I do not know how all these make flavours work.
I trust that your proposals will have improved everybody's experience.
according to my testing it worked for me

Thanks for your help

@rzr
Copy link
Collaborator Author

rzr commented Oct 6, 2018

You're welcome ! once merged I propose to tag a new release.

I am granted to merge this is anyone against this ?

@HomeACcessoryKid
may I suggest you to edit this wiki page:
https://github.com/ganzziani/xscopes-qt/wiki

@rzr
Copy link
Collaborator Author

rzr commented Oct 10, 2018

Is anyone against merging this ?

cc: @ganzziani

@rzr rzr merged commit 49db054 into ganzziani:master Oct 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants