Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect result in IsFactorisableInverseMonoid for an ideal #530

Closed
wilfwilson opened this issue Sep 20, 2018 · 4 comments
Closed

Incorrect result in IsFactorisableInverseMonoid for an ideal #530

wilfwilson opened this issue Sep 20, 2018 · 4 comments
Assignees
Labels
bug Label for issues or PR which report or fix bugs resolved-pending-release A label for issues that are resolved pending a release.

Comments

@wilfwilson
Copy link
Collaborator

I and J are equal, but one is a factorisable inverse monoid, and the other is not:

gap> S := SymmetricInverseMonoid(5);;
gap> I := MinimalIdeal(S);;
gap> IsFactorisableInverseMonoid(I);
false
gap> J := InverseMonoid(I);;
gap> I = J;
true
gap> IsFactorisableInverseMonoid(J);
true
@wilfwilson wilfwilson added the bug Label for issues or PR which report or fix bugs label Sep 20, 2018
@james-d-mitchell
Copy link
Collaborator

Yikes, thanks for the report @wilfwilson!

@james-d-mitchell
Copy link
Collaborator

For info the old method for IsFactorisableInverseMonoid for an ideal is:

InstallMethod(IsFactorisableInverseMonoid, "for an inverse semigroup ideal",
[IsSemigroupIdeal and IsInverseSemigroup],
function(I)
  if I = SupersemigroupOfIdeal(I) then
    return IsFactorisableInverseMonoid(SupersemigroupOfIdeal(I));
  fi;
  return false;
end);

This is clearly incorrect, as your example shows. A fix is in the works.

@james-d-mitchell
Copy link
Collaborator

Fixed by PR #539

@james-d-mitchell james-d-mitchell added resolved-pending-merge A label for issues that are resolved pending a PR merge. close-on-minor-release resolved-pending-release A label for issues that are resolved pending a release. and removed resolved-pending-merge A label for issues that are resolved pending a PR merge. labels Sep 26, 2018
@james-d-mitchell james-d-mitchell self-assigned this Sep 29, 2018
@james-d-mitchell
Copy link
Collaborator

Resolved in v3.0.20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Label for issues or PR which report or fix bugs resolved-pending-release A label for issues that are resolved pending a release.
Projects
None yet
Development

No branches or pull requests

2 participants