Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

semigroups: operator \< #568

Merged
merged 1 commit into from
Nov 27, 2018
Merged

semigroups: operator \< #568

merged 1 commit into from
Nov 27, 2018

Conversation

james-d-mitchell
Copy link
Collaborator

This commit adds a generic operator < for semigroups, with special versions
for transformation semigroups, pbr semigroups, and bipartitions.

@james-d-mitchell james-d-mitchell added the new-feature A label for PRs that contain new features label Nov 26, 2018
wilfwilson
wilfwilson approved these changes Nov 26, 2018
View reviewed changes
Copy link
Collaborator

@wilfwilson wilfwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Do you think you should add one of these things small methods for partial perm semigroups? Semigroups of partial perms would work under the current PR, but perhaps would be better if you did that.

@wilfwilson
Copy link
Collaborator

This addresses #561.

@james-d-mitchell
semigroups: operator \<
7c1a77c 
This commit adds a generic operator \< for semigroups, with special versions
for transformation semigroups, pbr semigroups, and bipartitions.
@james-d-mitchell
Copy link
Collaborator Author

@wilfwilson done!

@wilfwilson wilfwilson merged commit 83c7f38 into semigroups:stable-3.1 Nov 27, 2018
@james-d-mitchell james-d-mitchell mentioned this pull request Nov 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilfwilson wilfwilson wilfwilson approved these changes

Assignees
No one assigned
Labels
new-feature A label for PRs that contain new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@james-d-mitchell @wilfwilson