Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make last and last2 and last3 (and time) thread-local #62

Closed
stevelinton opened this issue Mar 17, 2015 · 4 comments
Closed

Make last and last2 and last3 (and time) thread-local #62

stevelinton opened this issue Mar 17, 2015 · 4 comments
Assignees
@stevelinton
Labels
gapdays2015-spring Issues and PRs that arose at https://www.gapdays.de/gapdays2015-spring topic: HPC-GAP Issues and PRs related to HPC-GAP

Comments

@stevelinton
Copy link
Contributor

Title says it all.
@stevelinton stevelinton added the topic: HPC-GAP Issues and PRs related to HPC-GAP label Mar 17, 2015
@stevelinton stevelinton self-assigned this Mar 17, 2015
@fingolfin fingolfin added the gapdays2015-spring Issues and PRs that arose at https://www.gapdays.de/gapdays2015-spring label Mar 17, 2015
@stevelinton
Copy link
Contributor Author

This arose from the standard check using NamesSystemGVars. It seems that that also returns Thread Local Variables so last and co might already be threadlocal. So we need a way to test whether a global is thread-local.

@rbehrends
Copy link
Contributor

IsBound(ThreadVar.("foo")) returns true iff foo is thread-local variable.

@stevelinton
Copy link
Contributor Author

Turns out you do need to look in the kenrel to get a correct answer when foo is UnBound. This is now all in a pull request. Incidentally, skipping thread-local variables reduces the number of thread-local objects in globals to about 70.

@olexandr-konovalov
Copy link
Member

Thanks - I've merged PR #68 and updated the wiki page https://github.com/gap-system/gap/wiki/Making-the-GAP-code-thread-safe. Closing this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevelinton stevelinton

Labels
gapdays2015-spring Issues and PRs that arose at https://www.gapdays.de/gapdays2015-spring topic: HPC-GAP Issues and PRs related to HPC-GAP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fingolfin @rbehrends @olexandr-konovalov @stevelinton