Hpcgap lib merge 1 #1327
Merged
Hpcgap lib merge 1 #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1327 +/- ##
==========================================
- Coverage 61.54% 61.52% -0.03%
==========================================
Files 1038 1035 -3
Lines 358268 356356 -1912
Branches 14291 14293 +2
==========================================
- Hits 220492 219234 -1258
+ Misses 134120 133461 -659
- Partials 3656 3661 +5
|
fingolfin
approved these changes
May 10, 2017
fingolfin
approved these changes
May 10, 2017
ChrisJefferson
force-pushed
the
hpcgap-lib-merge-1
branch
from
e78544a
to
370aa2f
Compare
|
This has been rebased on top of #1333 (MakeImm and Imm), and that is used to do some more simple merging. |
|
It also requires #1334 as well (sorry) |
ChrisJefferson
force-pushed
the
hpcgap-lib-merge-1
branch
2 times, most recently
from
7b633bc
to
15e84dd
Compare
|
OK, #1334 is in -- please rebase this PR so that we can merge it. |
|
Or wait, I'll just do it |
fingolfin
force-pushed
the
hpcgap-lib-merge-1
branch
from
15e84dd
to
7e065a7
Compare
ChrisJefferson
force-pushed
the
hpcgap-lib-merge-1
branch
from
7e065a7
to
aca664a
Compare
|
Ah well, seems we both did it... also fine :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch merges some files in hpcgap/lib. It also makes a wide selection of strings which GAP creates immutable -- in many cases if these strings were edited bad things would happen, so making them immutable shouldn't break anything.