Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MakeImm and Imm #1333

Merged
merged 1 commit into from
May 12, 2017
Merged

Add MakeImm and Imm #1333

merged 1 commit into from
May 12, 2017

Conversation

ChrisJefferson
Copy link
Contributor

This adds two shorthands, MakeImm for MakeImmutable, and Imm for Immutable. These are because we want to call these functions a lot in HPC-GAP, and so having shorter names is useful.

@ChrisJefferson ChrisJefferson force-pushed the MakeImm branch 2 times, most recently from 63da59e to 96be0fc Compare May 11, 2017 14:24
@codecov
Copy link

codecov bot commented May 11, 2017

Codecov Report

Merging #1333 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1333      +/-   ##
==========================================
- Coverage   61.48%   61.47%   -0.01%     
==========================================
  Files        1049     1049              
  Lines      365572   365471     -101     
  Branches    15163    15129      -34     
==========================================
- Hits       224755   224661      -94     
- Misses     136797   136802       +5     
+ Partials     4020     4008      -12
Impacted Files Coverage Δ
lib/object.gd 50% <ø> (ø) ⬆️
hpcgap/lib/object.gd 50% <ø> (ø) ⬆️
lib/files.gi 36.47% <0%> (-17.63%) ⬇️
lib/files.gd 56.98% <0%> (-5.38%) ⬇️
src/system.c 51.03% <0%> (-3.06%) ⬇️
src/objects.h 68.42% <0%> (-2.42%) ⬇️
hpcgap/pkg/gapdoc/PackageInfo.g 33.33% <0%> (-1.29%) ⬇️
lib/pager.gi 7.27% <0%> (-0.61%) ⬇️
lib/init.g 45.38% <0%> (-0.28%) ⬇️
src/funcs.c 63.92% <0%> (-0.14%) ⬇️
... and 6 more

@markuspf markuspf merged commit f34f576 into gap-system:master May 12, 2017
@ChrisJefferson ChrisJefferson deleted the MakeImm branch May 12, 2017 11:26
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.9.0 milestone Jan 20, 2018
@olexandr-konovalov olexandr-konovalov added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Jan 20, 2018
@olexandr-konovalov
Copy link
Member

This is reverted in master in #2122 and cherry-picked onto stable-4.9. Removed mentioning this from the release notes for GAP 4.9.

@olexandr-konovalov olexandr-konovalov added release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes and removed release notes: added PRs introducing changes that have since been mentioned in the release notes labels Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants