deal with unwanted side-effects of #3006 #5336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Let the filters created by `DeclareHandlingByNiceBasis` imply `IsFreeLeftModule`. This was the case before the changes from gap-system#3006, and this change fixes the problem described in gap-system#5322, as I had sketched in the discussion of gap-system#5325. - Document this change (following gap-system#5325). - Increase the rank of `IsHandledByNiceBasis` by 2. Then we get back to the rank before the changes from gap-system#3006. This way, the `\in` method with second argument in `IsFreeLeftModule and IsHandledByNiceBasis` is again ranked higher than the one with second argument `IsFreeLeftModule and IsFiniteDimensional`. The bug described in issue gap-system#5334 which has been found because of the reordering of these two methods (due to gap-system#3006) gets fixed via pull request gap-system#5335, now we can return to the better method ordering. (I do not like uprankings, but I have no better idea to solve this problem.)
ThomasBreuer
added
kind: bug
fingolfin
approved these changes
Jan 19, 2023
This was referenced Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeclareHandlingByNiceBasisimplyIsFreeLeftModule. This was the case before the changes from Forbid installing new implications to representations usingInstallTrueMethod#3006, and this change fixes the problem described in Regression inDeclareHandlingByNiceBasis/InstallHandlingByNiceBasis#5322, as I had sketched in the discussion of fix the documentation ofDeclareHandlingByNiceBasis#5325.DeclareHandlingByNiceBasis#5325).IsHandledByNiceBasisby 2. Then we get back to the rank before the changes from Forbid installing new implications to representations usingInstallTrueMethod#3006. This way, the\inmethod with second argument inIsFreeLeftModule and IsHandledByNiceBasisis again ranked higher than the one with second argumentIsFreeLeftModule and IsFiniteDimensional. The bug described in issue Regression: recent changes caused packageguavato fail its test suite #5334 which has been found because of the reordering of these two methods (due to Forbid installing new implications to representations usingInstallTrueMethod#3006) gets fixed via pull request Fix a case whereCoefficients(B,v)returned a list instead offailalthough the vectorvdid not lie in the underlying vector spaceVofB#5335, now we can return to the better method ordering. (I do not like uprankings, but I have no better idea to solve this problem.)