fix the documentation of DeclareHandlingByNiceBasis
#5325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since pull request gap-system#3006 go merged, the statement about the implication installed by `InstallHandlingByNiceBasis` was not correct. This change addresses issue gap-system#5322.
ThomasBreuer
added
kind: bug
fingolfin
reviewed
Jan 18, 2023
There was a problem hiding this comment.
Technically that means our changes to DeclareHandlingByNiceBasis were breaking.
To me that indicates we should...
- carefully consider if we really want to introduce this breakage, or perhaps instead revert it (it may be "right", but is it worth the trouble? )
- if we do, then we should document it explicitly as a breaking change in the release notes
- ... and also check for affected packages. A quick grep show that it is used in
fr,guava,quagroup,qpa.
|
@fingolfin The problem described in issue #5322 arises because the QPA2 package wants to install a I could modify the code such that the filters created by |
fingolfin
approved these changes
Jan 18, 2023
ThomasBreuer
added a commit
to ThomasBreuer/gap
that referenced
this pull request
Jan 19, 2023
- Let the filters created by `DeclareHandlingByNiceBasis` imply `IsFreeLeftModule`. This was the case before the changes from gap-system#3006, and this change fixes the problem described in gap-system#5322, as I had sketched in the discussion of gap-system#5325. - Document this change (following gap-system#5325). - Increase the rank of `IsHandledByNiceBasis` by 2. Then we get back to the rank before the changes from gap-system#3006. This way, the `\in` method with second argument in `IsFreeLeftModule and IsHandledByNiceBasis` is again ranked higher than the one with second argument `IsFreeLeftModule and IsFiniteDimensional`. The bug described in issue gap-system#5334 which has been found because of the reordering of these two methods (due to gap-system#3006) gets fixed via pull request gap-system#5335, now we can return to the better method ordering. (I do not like uprankings, but I have no better idea to solve this problem.)
fingolfin
pushed a commit
that referenced
this pull request
Jan 19, 2023
- Let the filters created by `DeclareHandlingByNiceBasis` imply `IsFreeLeftModule`. This was the case before the changes from #3006, and this change fixes the problem described in #5322, as I had sketched in the discussion of #5325. - Document this change (following #5325). - Increase the rank of `IsHandledByNiceBasis` by 2. Then we get back to the rank before the changes from #3006. This way, the `\in` method with second argument in `IsFreeLeftModule and IsHandledByNiceBasis` is again ranked higher than the one with second argument `IsFreeLeftModule and IsFiniteDimensional`. The bug described in issue #5334 which has been found because of the reordering of these two methods (due to #3006) gets fixed via pull request #5335, now we can return to the better method ordering. (I do not like uprankings, but I have no better idea to solve this problem.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since pull request #3006 got merged, the statement about the implication installed by
InstallHandlingByNiceBasiswas not correct.This change addresses issue #5322.