Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unittest with pytest #129

Closed
1 of 3 tasks
danyeaw opened this issue Apr 5, 2019 · 7 comments
Closed
1 of 3 tasks

Replace unittest with pytest #129

danyeaw opened this issue Apr 5, 2019 · 7 comments
Labels
first-timers-only This makes an excellent first contribution hacktoberfest up-for-grabs Any takers?

Comments

@danyeaw
Copy link
Member

danyeaw commented Apr 5, 2019

It would be very nice to convert our test suite to use pytest. It has really nice fixtures using decorators, simple assert statements, and many other very nice features. There is a python tool called unittest2pytest that can help automate parts of this conversion.

I'm submitting a...

  • Bug report
  • Feature request
  • Documentation issue or request
@amolenaar
Copy link
Member

Let's just pick this up as we go. I created Pytest tests for the Namespace component. It works really nice. Let's just update the tests when we have to edit them.

We can keep this issue open as a reminder.

@danyeaw danyeaw added this to the 1.2.0 milestone Oct 28, 2019
@danyeaw danyeaw added up-for-grabs Any takers? and removed ongoing labels Feb 2, 2020
@danyeaw
Copy link
Member Author

danyeaw commented Feb 2, 2020

With #262 converting a few more tests, we should only have a couple of tests left to convert.

@danyeaw danyeaw added the first-timers-only This makes an excellent first contribution label Feb 2, 2020
@Shubhangi2901
Copy link

Started working on this

@amolenaar amolenaar removed this from the 1.2.0 milestone Feb 21, 2020
@pratheekcr
Copy link

Hi, I am new to open source and this issue would be a great way to start. Is this still open? Let me know, please.

@danyeaw
Copy link
Member Author

danyeaw commented Jan 10, 2021

@pratheekcr Yes, it is still open. We have converted a lot of our tests to pytest, but there are still some unitest ones that remain. We would love to get your help with it!

@TiemenSch
Copy link
Contributor

As a first-timer on this repo, I'm trying to find my way through this one. I think the other attempt(s) for this issue have sort of come to a halt? In any case, I only have the UML directory left to do.

@danyeaw
Copy link
Member Author

danyeaw commented Feb 16, 2021

Closed by #658

@danyeaw danyeaw closed this as completed Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only This makes an excellent first contribution hacktoberfest up-for-grabs Any takers?
Projects
None yet
Development

No branches or pull requests

5 participants