Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Some Profile Tests to Pytest #294

Merged
merged 5 commits into from Apr 8, 2020
Merged

Conversation

danyeaw
Copy link
Member

@danyeaw danyeaw commented Apr 6, 2020

This PR continues conversion towards closure of #129.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the current behavior?

All profile tests are using unittest

Issue Number: #129

What is the new behavior?

Some profile tests are using PyTest

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Signed-off-by: Dan Yeaw <dan@yeaw.me>
Signed-off-by: Dan Yeaw <dan@yeaw.me>
Signed-off-by: Dan Yeaw <dan@yeaw.me>
@github-actions github-actions bot added the chore Maintenance related PR label Apr 6, 2020
Signed-off-by: Dan Yeaw <dan@yeaw.me>
Signed-off-by: Dan Yeaw <dan@yeaw.me>
@danyeaw danyeaw added this to the 1.3 milestone Apr 7, 2020
@danyeaw danyeaw merged commit 30eec2e into master Apr 8, 2020
@danyeaw danyeaw deleted the chore/pytest-profiles branch April 8, 2020 01:36
@danyeaw danyeaw modified the milestones: 1.3, 2.0 Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants