No application singleton #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amolenaar
force-pushed
the
no-application-singleton
branch
3 times, most recently
from
9eb3a84
to
341a503
Compare
And reuse it by tests as well.
Handlers are registered on the session for now. This maintains backwards compatibility.
Just instantiate the session. Only use application when multiple sessions are in play.
Convert test_undo to pytest and remove test_issue_132.
no longer a special singleton thingy.
amolenaar
force-pushed
the
no-application-singleton
branch
from
341a503
to
551ed09
Compare
danyeaw
reviewed
Feb 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
no api changes)What is the current behavior?
Gaphor has one
Applicationsingleton. This does not match the current model.Issue Number: N/A
What is the new behavior?
Applicationwill be an ordinary object, instantiated as part of theGtk.Applicationstartup and bound to theGtk.Applicationlifecycle.Applicationan ordinary objectDoes this PR introduce a breaking change?
Other information
This PR builds on #259.