Fix editor crashes #109
Merged
Fix editor crashes #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're not there yet, as there are entries registered that are not deregistered properly.
|
@amolenaar In Linux, I can open the editor now, but it is blank:
Then if I close the editor, I can't reopen it. |
|
Yes, I ran into that. It's fixed now, also for the console. |
This way I can at least control how it's created and terminated in a way that does not crash or hangs the window. Also the PropertyEditor has been merged with ElementEditor, since the state of both classes is closely aligned.
amolenaar
force-pushed
the
fix-editor-crashes
branch
from
296f7a6
to
585700e
Compare
Signed-off-by: Dan Yeaw <dan@yeaw.me>
Signed-off-by: Dan Yeaw <dan@yeaw.me>
Signed-off-by: Dan Yeaw <dan@yeaw.me>
|
@amolenaar Sorry, I didn't need to prematurely review this if you were still working on it. These changes look awesome, really nice job fixing all of the editor issues 👍 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're not there yet, as there are entries registered that are not deregistered
properly.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Open, close and open Editor (in Edit menu). Gaphor crashes.
Issue Number: #96
What is the new behavior?
Opening and closing works as expected.
Tasks