Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tree cell rendering #377

Merged
merged 2 commits into from Jul 31, 2020
Merged

Fix tree cell rendering #377

merged 2 commits into from Jul 31, 2020

Conversation

amolenaar
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the current behavior?

Text in tree-view is misbehaving if you enter something between angular brackets, e.g. Class<Type>

Issue Number: #376

What is the new behavior?

You can enter those characters. Style (italic/bold) is set on cell level.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Also fix rendering in diagram when you remove the name (e.g. for Classes)

@amolenaar amolenaar linked an issue Jul 29, 2020 that may be closed by this pull request
7 tasks
@gaphor gaphor deleted a comment from sourcery-ai bot Jul 29, 2020
@amolenaar amolenaar added this to the 2.0 milestone Jul 29, 2020
@amolenaar amolenaar requested a review from danyeaw July 30, 2020 13:35
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update to fix the bug and make use of Pango!

@danyeaw danyeaw added the bug An issue in the application label Jul 31, 2020
@danyeaw danyeaw merged commit 1c353de into master Jul 31, 2020
@danyeaw danyeaw deleted the fix-tree-cell-rendering branch July 31, 2020 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue in the application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certain Characters in Object Name Causes Odd UI Behavior
2 participants