Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger updates on name and stereotype change #382

Merged
merged 1 commit into from Jul 31, 2020

Conversation

amolenaar
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the current behavior?

Issue Number: #374

What is the new behavior?

Name and stereotype do update (may require #377 to work properly, since empty text strings do no cause an update).

Does this PR introduce a breaking change?

  • Yes
  • No

@amolenaar amolenaar requested a review from danyeaw July 30, 2020 19:12
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 30, 2020

Sourcery Code Quality Report (beta)

❌  Merging this PR will decrease code quality in the affected files by 0.03 out of 10.

Quality metrics Before After Change
Complexity 3.80 3.80 0.00
Method Length 107.88 109.88 2.00 🔴
Quality 7.49 7.46 -0.03 🔴
Other metrics Before After Change
Lines 141 144 3
Changed files Quality Before Quality After Quality Change
gaphor/UML/actions/partition.py 7.49 7.46 -0.03 🔴

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Overall Recommendation
gaphor/UML/actions/partition.py PartitionItem.pre_update 8 233.78 5.09 Split out functionality
gaphor/UML/actions/partition.py PartitionItem.draw_partition 8 182.84 5.59 Split out functionality

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it via email or our Gitter!

@github-actions github-actions bot added the fix A fix for a bug label Jul 30, 2020
@amolenaar amolenaar linked an issue Jul 30, 2020 that may be closed by this pull request
7 tasks
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are on a roll, thanks for the bug fix 🎉

@danyeaw danyeaw merged commit da5cfab into master Jul 31, 2020
@danyeaw danyeaw deleted the fix/374-partition-name branch July 31, 2020 01:15
@danyeaw danyeaw added bug An issue in the application and removed fix A fix for a bug labels Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue in the application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swimlane Name Change Doesn't Update on the Diagram
2 participants