Fix undo tests #91
Merged
Fix undo tests #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way there are no "left overs" that cause other tests to fail.
This was referenced Mar 11, 2019
Merged
danyeaw
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Tests fail due to inconsistent transaction state.
Issue Number: #75
What is the new behavior?
Tests work due to restructured transaction test.
Other information
One might argue that the state that was left behind from the transaction test should be fixed as part of the entire test case. That the "stack" (static) class variable of the Transaction class should not be there. For now this fixes the problem and future design improvements can focus on removing the class-wide variable in a way that allows for easy testing and (more) reliable execution.