Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistancy in using typedefs #85

Closed
MusicMonkey5555 opened this issue Oct 15, 2012 · 1 comment
Closed

Consistancy in using typedefs #85

MusicMonkey5555 opened this issue Oct 15, 2012 · 1 comment
Labels

Comments

@MusicMonkey5555
Copy link
Contributor

This is the only place I noticed it but found it a bit odd. Not really a bug, but think it should be changed none the less. In Engine\source\platform\types.h

getMin for both float and double (line 221 & 227) use the words float and double rather than the typecast F32 and F64 where as all the others use them.

Simple enough change. Once I start getting pull requests working I can add this if someone else doesn't before me.

@crabmusket
Copy link
Contributor

Appears fixed now :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants